Conversation
|
Hi @aryan1306! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
Fixes #58578.
When ScrollView content shrinks, layout can clamp the current scroll offset before
maintainVisibleContentPositionadjusts the visible anchor. Applying the anchor delta to that clamped offset can move the list to the top.Capture the scroll offset before mounting and use it when applying the anchor adjustment in Android and iOS Fabric. Add regression tests for vertical and horizontal shrinking content.
Changelog:
[GENERAL] [FIXED] - Preserve the visible ScrollView anchor when content shrinks.
Test Plan:
./gradlew :packages:react-native:ReactAndroid:testDebugUnitTest --tests com.facebook.react.views.scroll.MaintainVisibleScrollPositionHelperTest --no-daemon: all three tests passed.RNTesterUnitTestsscheme on an iPhone 17 Pro simulator: all three tests inRCTScrollViewComponentViewTestspassed, including the vertical and horizontal shrink regressions.