Repository navigation
rmodels: validate IQM file offsets against data size - #6367
Closed
TristanInSec wants to merge 1 commit into
Closed
TristanInSec wants to merge 1 commit into
TristanInSec wants to merge 1 commit into
Conversation
The IQM loader reads offset and count fields from the file header and uses them directly in memcpy calls without checking they fall within the loaded file data. A crafted .iqm file with out-of-range offsets causes heap buffer over-reads. Validate the main header offsets (meshes, triangles, vertex arrays, joints) against the file size before use, and check per-element offsets (text strings, vertex data) before each memcpy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IQM model loader reads offset and count fields from the file header and passes them directly to memcpy without checking they fit within the loaded data. A crafted .iqm with out-of-range offsets reads past the file buffer.
This validates the header-level offsets (meshes, triangles, vertex arrays, joints) up front, and checks per-element offsets (text strings, vertex array data) before each copy.