Skip to content

[rcore] Fix FileCopy() and FileMove() reporting success when the copy failed #6364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raysan5 merged 2 commits into from
Nov 10, 2026
+5 −6
Merged

[rcore] Fix FileCopy() and FileMove() reporting success when the copy failed #6364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c34c5e6
[rcore] Fix `FileCopy()` and `FileMove()` reporting success when the …
b84330808 Nov 4, 2026
018a432
FileMove: drop the extra failure result, FileCopy already reports it
b84330808 Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/rcore.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2243,13 +2243,12 @@ int FileCopy(const char *srcPath, const char *dstPath)
int srcDataSize = 0;
unsigned char *srcFileData = LoadFileData(srcPath, &srcDataSize);

// Create required paths if they do not exist
if (DirectoryExists(GetDirectoryPath(dstPath))) result = 0; // Already exists
else result = MakeDirectory(GetDirectoryPath(dstPath));

if (result == 0) // Directory created successfully or already exists
if ((srcFileData != NULL) && (srcDataSize > 0))
{
if ((srcFileData != NULL) && (srcDataSize > 0))
// Create required paths if they do not exist
const char *dstDirPath = GetDirectoryPath(dstPath);

if (DirectoryExists(dstDirPath) || (MakeDirectory(dstDirPath) == 0)) // Directory created successfully or already exists
{
bool saved = SaveFileData(dstPath, srcFileData, srcDataSize);
if (saved) result = 0;
Expand Down
Loading