Repository navigation
[rcore][drm] Fix ESC closing the window despite SetExitKey(KEY_NULL) - #6343
Merged
Merged
Conversation
The stdin keyboard (SUPPORT_SSH_KEYBOARD_RPI) wrote a single ESC byte directly into the state of the exit key. With SetExitKey(KEY_NULL), that is currentKeyState[0], which the exit key check then found set, so ESC still closed the window. Map a single ESC byte to KEY_ESCAPE like the other keys, and skip the exit key check for KEY_NULL. ESC still closes the window by default, and IsKeyPressed(KEY_ESCAPE) now works with the stdin keyboard too.
Owner
|
@maiphi thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stdin keyboard (
SUPPORT_SSH_KEYBOARD_RPI) wrote a single ESC byte directly into the state of the exit key. WithSetExitKey(KEY_NULL), that iscurrentKeyState[0], which the exit key check then found set, so ESC still closed the window.Map a single ESC byte to
KEY_ESCAPElike the other keys, and skip the exit key check forKEY_NULL. ESC still closes the window by default, andIsKeyPressed(KEY_ESCAPE)now works with the stdin keyboard too.Fixes #6342.