Repository navigation
[rcore] Fix GetDirectoryPath() and GetPrevDirectoryPath() overflo… - #6331
Open
akashdeshmukh-git wants to merge 1 commit into
Open
akashdeshmukh-git wants to merge 1 commit into
akashdeshmukh-git wants to merge 1 commit into
Conversation
…wing their buffer on long paths Both functions copied the directory part of the path into a static buffer of MAX_FILEPATH_LENGTH bytes without checking its length, so a longer path (more than 260 characters on Windows, where long paths are allowed since Windows 10) wrote past the buffer. Such paths now return an empty string with a warning, as other path functions skip paths that are too long. GetDirectoryPath() also read past the end of an empty string when checking for a drive letter.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…wing their buffer on long paths
Both functions copied the directory part of the path into a static buffer of MAX_FILEPATH_LENGTH bytes without checking its length, so a longer path (more than 260 characters on Windows, where long paths are allowed since Windows 10) wrote past the buffer. Such paths now return an empty string with a warning, as other path functions skip paths that are too long.
GetDirectoryPath() also read past the end of an empty string when checking for a drive letter.