Repository navigation
chore: migrate lab Bicep extensions to GHCR - #20
Draft
willdavsmith wants to merge 1 commit into
Draft
willdavsmith wants to merge 1 commit into
willdavsmith wants to merge 1 commit into
Conversation
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the two active lab Radius Bicep extension references to
br:ghcr.io/radius-project/bicep-types-radius:edgeand enableexperimentalFeaturesEnabled.ociEnabledin both effective configs. Lab 001's development ACRlatestbecomes GHCRedge; lab 002 retainsedgeintent.Preserve all four checked-in local custom extension references and packages, all resource declarations, and unrelated recipes/images/settings. In particular, lab 001's
radiusDataprovides the customRadius.Data/postgreSqlDatabasestype; it is not an obsolete built-in per-namespace alias and must not be collapsed intoradius. NoradiusCompute/radiusSecurityaliases or active AWS extension consumers were found. No stable/version/digest pins needed migration, and no tooling/framework pins are introduced.Keep this PR draft. Pre-merge gates:
edgetag are public. Both canonical Radius and AWS anonymous pull-token endpoints currently return HTTP 403; AWS is a parent rollout gate, not a new lab consumer.pkg/cli/bicep/tools/download_tools.go. The local standalone Bicep reports 0.46.1 (545b338e2c), but localrad versionreports Radius 0.60.0 / Bicep 0.42.1. No machine-wide tooling was changed; full released-Radius integration is still unverified.Reason for change
Adopt the approved production ACR-to-GHCR extension migration for active lab consumers. No issue is automatically closed.
A tracked-text scan found no remaining
azurecr.ioreferences after these two substitutions. The local custom aliases remain intentional. Neither lab consumesbr:ghcr.io/radius-project/bicep-types-aws, so no AWS entry is added. No historical material, Test-tenant settings, recipe/image registries, deployments, publishing workflows, registry visibility/settings, or ACR resources are changed.How to test
Passed:
python3 -m json.tool 001-customer-support-agent/radius/bicepconfig.json > /dev/nullpython3 -m json.tool 002-order-console/radius/bicepconfig.json > /dev/nullgit diff --checkgit grep -n -I -e 'azurecr\.io' -- .returned exit 1 with no matches, the expected clean inventory result.git show HEAD:<path>before committing: only the Radius URI and OCI flag changed; all local artifact paths still exist; these two configs are the nearest effective config for all six lab 001 templates and all three lab 002 templates.Existing Markdown lint failures, no new diagnostics:
npx --yes --package markdownlint-cli2 markdownlint-cli2 --config .github/linters/.markdownlint-cli2.yaml README.md 001-customer-support-agent/README.md 002-order-console/README.mdExecuted markdownlint-cli2 0.23.3 / markdownlint 0.41.1 using the existing repository configuration. Exit 1: 54 existing findings. The same command against an untouched
git archive HEADsnapshot taken before the commit returned exit 1 with 55 findings. A diagnostic-multiset comparison passed: zero added diagnostics; the root README now has its missing final newline. Existing table formatting, HTML and code-fence findings are out of scope. No dependency manifest or lockfile was added.Live extension compilation blocked:
rad version— executed; local Radius 0.60.0 / Bicep 0.42.1 (older than the compatibility baseline).bicep --version— executed; standalone Bicep 0.46.1 (545b338e2c).bicep restore --pattern '*/radius/**/*.bicep' --forceandbicep restore 001-customer-support-agent/radius/app.bicep --forcereturned exit 0, but this is not extension-restore proof: actual compilation below fails.HOME,AZURE_CONFIG_DIR, andDOCKER_CONFIGpointed at a fresh isolated temporary directory, executedbicep build "$template" --stdoutfor every path returned bygit ls-files '*.bicep'. All 9/9 exited 1 with BCP192 and GHCR HTTP 403 forbr:ghcr.io/radius-project/bicep-types-radius:edge. Coverage: lab 001app,env,shared-resources, recipesagent,blobstorage,postgres; lab 002app, environmentsazure,kubernetes. No output was written into the repository. Local custom references produced no separate errors, but full type compatibility cannot be certified while the remote Radius artifact is unavailable.curl -sS -o /dev/null -w 'Anonymous GHCR Radius token: HTTP %{http_code}\n' 'https://ghcr.io/token?service=ghcr.io&scope=repository:radius-project/bicep-types-radius:pull'— HTTP 403.curl -sS -o /dev/null -w 'Anonymous GHCR AWS token: HTTP %{http_code}\n' 'https://ghcr.io/token?service=ghcr.io&scope=repository:radius-project/bicep-types-aws:pull'— HTTP 403.The README documents rerunning actual builds in a clean unauthenticated environment after publication. No relevant automated Bicep/config test suite is defined in this repository; application runtime tests and cloud deployment were not run for this config/docs-only change. This PR does not claim live compilation, deployment, or release integration passed.
File change summary
001-customer-support-agent/radius/bicepconfig.jsonedge, OCI enabled; three local custom extensions preserved.002-order-console/radius/bicepconfig.jsonedge, OCI enabled; local Dapr extension preserved.README.md001-customer-support-agent/README.md002-order-console/README.md