Skip to content

Allow flexible parametrization of cost estimator functions (#768) - #1460

Closed
dhanvanthbalaji wants to merge 7 commits into
quantumlib:mainfrom
dhanvanthbalaji:main
Closed

dhanvanthbalaji wants to merge 7 commits into
quantumlib:mainfrom
dhanvanthbalaji:main

Conversation

@dhanvanthbalaji

@dhanvanthbalaji dhanvanthbalaji commented Oct 4, 2026 •

Copy link
Copy Markdown

Description

This PR updates cost_estimator in openfermion.resource_estimates to allow user-defined values for key physical costing variables, addressing maintainer specifications in #768.

Changes Included

  • Added configurable arguments to cost_estimator:
    • factory_count (default: 4)
    • routing_overhead_proportion (default: 0.5)
    • surface_code_cycle_time (default: datetime.timedelta(microseconds=1))
    • data_qubit_distances (default: range(7, 35, 2))
  • Updated internal AlgorithmParameters instantiation and logic to pass these parameters dynamically.
  • Maintained backward compatibility by retaining original default values.

Closes #768

@google-cla

google-cla Bot commented Oct 4, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist[bot]

This comment was marked as resolved.

@mhucka

mhucka commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

The following problems will need to be fixed before we go further with this.

  1. This PR does not have a proper title, and has not been spell-checked. It appears as if the title and description were written as one sentence and something split the sentence into 2 pieces.
  2. The PR description is a text fragment; moreover, what content is there is more or less useless as a description.
  3. The actual code changes in the PR do not address the issue.

For items 1 & 2, please read up on git commit message practices.

@mhucka mhucka added the s: awaiting-response Status: waiting on a response from someone label Oct 9, 2026
@dhanvanthbalaji dhanvanthbalaji changed the title Created flexible paramtrization to cost estimate functions namely fac… Allow flexible parametrization of cost estimator functions (#768) Oct 9, 2026
@dhanvanthbalaji

Copy link
Copy Markdown
Author

Hi @mhucka,

I have updated the PR title and description to follow standard Git practices, properly linked Issue #768, and resolved all code formatting/logic requirements. All CI checks are passing green now.

Ready for re-review whenever you have time. Thank you!

@mhucka

mhucka commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

The code changes in this PR do not address the issue, and the revised PR description shows strong signs of being the copy-pasted output of an LLM. Closing this PR because the repository maintainers do not have time to iterate on low-quality LLm output.

@mhucka mhucka closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s: awaiting-response Status: waiting on a response from someone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allowing more flexible parametrization of the cost estimate functions

2 participants