Repository navigation
[mypyc] Add primitive for chr - #22407
Open
Jahongir-Qurbonov wants to merge 2 commits into
Open
Jahongir-Qurbonov wants to merge 2 commits into
Jahongir-Qurbonov wants to merge 2 commits into
Conversation
Call PyUnicode_FromOrdinal directly for short ints in the valid range. Out-of-range values raise the same exceptions as CPython, which differ between Python versions: 3.13+ always raises ValueError, while older versions raise OverflowError for values that don't fit in a C int. Part of mypyc/mypyc#644.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a primitive for
chr(int). Short ints in the valid range callPyUnicode_FromOrdinaldirectly, instead of looking upbuiltins.chrand calling it through vectorcall with a boxed argument.Out-of-range arguments raise the same exceptions as CPython. These differ between Python versions: 3.13+ always raises
ValueError, while 3.12 and earlier raiseOverflowErrorfor values that don't fit in a Cint.Tests compare the results against CPython for every code point and for a range of out-of-range values, including ints that don't fit in a short tagged int. They pass on Python 3.10, 3.12, 3.13 and 3.14.
Micro-benchmark (~2M calls,
chr(i)foriinrange(32, 1024), the same module compiled before and after this change, Python 3.13): 0.065s -> 0.019s.This covers the
chrpart of #15937, which has been inactive since 2024.ord(str)has since been added separately.Part of mypyc/mypyc#644.