Repository navigation
[mypyc] Allow abs() on native int types - #22367
Open
Pixeless001 wants to merge 1 commit into
Open
Pixeless001 wants to merge 1 commit into
Pixeless001 wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22363.
abs()on ani64,i32,i16oru8failed to type check (Argument 1 to "abs" has incompatible type "i64"), because the native int classes in mypy's ownmypy_extensionsstubs define__neg__,__pos__and__invert__but not__abs__. This adds it to the bundled stubs and to the test stubs.There's no specialized primitive for these types yet, so mypyc compiles the call through the generic
PyNumber_Absolutepath.