[kushwahaamar-dev]

Fixes #22290

attrs.define, attrs.mutable and attrs.frozen (and the attr. versions) default to order=False. Only the old attr.s API has order follow eq. The plugin applied the attr.s rule to all of them, so every @define class got __lt__ and friends, and this type checks fine:

import attrs

@attrs.define
class D:
    x: int

D(1) < D(2)  # TypeError at runtime

I added an order_default arg next to frozen_default/slots_default and pass False for the define/frozen makers. Explicit order=True still works, and attr.s is unchanged.

The crash in the issue is the same bug. The generated __lt__ replaces the __lt__: int attribute, then on the second pass _analyze_class asserts the node is a Var. With the default fixed, that example doesn't generate __lt__ anymore, but you can still hit the crash with an explicit order=True, so I changed the assert to an isinstance check.

testAttrsIncrementalArguments assumed attrs.frozen classes are orderable, so I updated its expected output. I also added two cases to check-plugin-attrs.test (both fail on master).

[github-actions]

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅