proto: honor RecursionLimit when skipping unknown groups - #72
AshSgDe29071999 wants to merge 1 commit into
Conversation
Unknown group fields were skipped with protowire.DefaultRecursionLimit, so UnmarshalOptions.RecursionLimit did not apply. Pass the remaining depth into ConsumeFieldValueDepth. Fixes golang/protobuf#1719
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thank you for your interest into contributing to this project. Unfortunately this project does not accept GitHub pull requests as the source-of-truth for this project is hosted at https://go.googlesource.com/protobuf. This project page on GitHub is a mirror of that other repository. If you would like to contribute to this project, please follow the contribution guidelines for instructions on how to send a change. If the change you'd like to make is more substantial or introduces any new features, then it should first be discussed on the issue tracker. |
2 participants
Unknown group fields were skipped with
protowire.DefaultRecursionLimit(10000), ignoringUnmarshalOptions.RecursionLimit. Nested unknown groups were only rejected at ~10002 levels.ConsumeFieldValueDepthnow receives the remaining unmarshal depth on the unknown-field path (slow unmarshal, generated impl, and lazy impl).Related: golang/protobuf#1719