Repository navigation
config: synchronize OAuth2 transport replacement and cleanup - #1040
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
ViktorBystrov72
force-pushed
the
fix/oauth2-transport-snapshot
branch
2 times, most recently
from
November 12, 2026 04:53
4488a8f to
c887d90
Compare
Signed-off-by: Виктор Быстров <anatema@bk.ru>
ViktorBystrov72
force-pushed
the
fix/oauth2-transport-snapshot
branch
from
November 13, 2026 08:39
c887d90 to
5269da4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent requests can race when an OAuth2 client secret is refreshed:
RoundTripcopies thelastRTpointer under its lock, thenoauth2.Transport.RoundTripreadsSourceafter the lock is released while another request overwrites it.CloseIdleConnectionsalso reads the token HTTP client without the lock used to replace it.Publish a new OAuth2 transport when replacing its source so in-flight requests keep an immutable transport. Snapshot the token client and base transport under the read lock before closing idle connections.
The regression uses concurrent HTTP requests, a rotating secret manager, and concurrent idle-connection cleanup.
go test -racereports both races on the parent implementation. It passes five consecutive runs after the fix.Validation:
make test GOOPTS=-racepassed with Go 1.27.3 and golangci-lint 2.14.0, including root tests, lint, license, and module-tidy checks.git diff --checkpassed.@roidelapluie @gotjosh