Repository navigation
config: decode HTTP headers from JSON configuration - #1037
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
ViktorBystrov72
force-pushed
the
fix/json-http-headers
branch
2 times, most recently
from
November 12, 2026 04:53
0def8da to
51b6394
Compare
Signed-off-by: Виктор Быстров <anatema@bk.ru>
ViktorBystrov72
force-pushed
the
fix/json-http-headers
branch
from
November 13, 2026 08:39
51b6394 to
eec54c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading JSON containing
http_headerscurrently succeeds but silently drops the headers.Headers.MarshalJSONwrites the header map inline, while the default decoder expects a nestedHeadersfield.Add the corresponding
UnmarshalJSONmethod. Extend the existing configuration round-trip test and HTTP request test to cover JSON values, secrets, and file-backed headers. Reserved header validation is also checked for JSON configuration. On the parent commit, the round trip loses the map and the server receives none of the configured headers.Validation:
make test GOOPTS=-racepassed with Go 1.27.3 and golangci-lint 2.14.0, including root tests, lint, license, and module-tidy checks.git diff --checkpassed.@roidelapluie @gotjosh