Repository navigation
expfmt: preserve the full range of sample timestamps - #1036
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
ViktorBystrov72
force-pushed
the
fix/extracted-sample-timestamps
branch
2 times, most recently
from
November 12, 2026 04:53
81357e9 to
2b719ad
Compare
Signed-off-by: Виктор Быстров <anatema@bk.ru>
ViktorBystrov72
force-pushed
the
fix/extracted-sample-timestamps
branch
from
November 13, 2026 08:39
2b719ad to
a0df2a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtractSamplesconverts each explicit protobuf millisecond timestamp to nanoseconds before converting it tomodel.Time. The multiplication overflows outside the nanosecond range:9223372036855milliseconds becomes-9223372036854, andmath.MaxInt64becomes-1.Both representations already use int64 milliseconds, so copy the timestamp directly for counters, gauges, untyped metrics, summaries, and both histogram types. Regression cases cover the overflow boundaries, int64 extremes, ordinary and negative timestamps, and the default timestamp when none is supplied. They fail on the parent commit and pass with this change.
Validation: root
go test ./...,go test -race ./expfmt -count=1,make lint, license checks, module-tidy checks, andgit diff --checkpassed with Go 1.27.3 and golangci-lint 2.14.0.@roidelapluie @gotjosh