Repository navigation
docs: resolve 43 false PBS support claims, preserving case-specific bidder codes - #6914
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6a30c8359
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@patmmccann we would have to look at each of these in more detail. Looked at 3 and they were all unique. PBS or PBjs true also doesn't mean they are currently in master if that is the assumption? It's kind of like docs. We don't delete docs except on rare occasions because other versions/publishers could still be active. It means they were once in Prebid essentially... Don't care much about changing that assumption but that is how it is throughout the docs. prebid/prebid-server-java#3096 - analytics adapter in server |
|
@patmmccann nope but its less work then just dealing with it for a week or two. People tie their docs to PBjs and Prebid Server and JS merges much faster so assume there are a few where they set their docs to both and JS got merged and we missed the Server flag. We try to have them break them out or hold the merge up. Also, don't think there is another place where Analytics Adapters for server are listed actually? Could be wrong. So a larger question on breaking them out I would assume. |
|
thinking about it don't think PBS true controls the displaying under the bidder search? So maybe it doesn't matter. **claude says it does control that. However, should it show up there probably not. Not sure how many other Analytics Adapters do that since there isn't an Analytics Adapters section like in JS. We could create one and just move the ones that use this flag that way? |
Summary
Resolve all 43 entries in the Docs say Prebid Server (
pbs: true), but neither PBS Go nor PBS Java has the bidder category of the product-sync report.pbs: false, leaving PBJS support unchanged. Wherepbs_app_supported: truewas present, set it tofalseas well, to avoid contradictory app support claims.pbs: trueand align PBS-specific names. PBS-onlyAdView→adview,progX→progxinbiddercode; dual-platformSMB,defineMedia,interactiveOffers,nextMillenniumretain their PBJSbiddercodeand gain an explicitpbs_biddercodewith the lowercase canonical PBS name.This avoids silently breaking client-side bidder codes or download-module names. Note: the new
pbs_biddercodemetadata is interpreted by the sync report in PR #6910, whose checker has been updated to honor it. Merge #6910 before/alongside this PR to clear the four dual-platform case warnings.No adapters are deleted and no
enable_downloadsettings are changed. All changes are front matter except a short clarifying note forSMBandAdView.Verification
Checked the changed docs against the original 43-item report, with case-only support kept distinct from unsupported code. CI pending.