Skip to content

docs: resolve 43 false PBS support claims, preserving case-specific bidder codes - #6914

Merged
patmmccann merged 5 commits into
masterfrom
fix/pbs-docs-false-positives-43-20261031
Oct 31, 2026
Merged

patmmccann merged 5 commits into
masterfrom
fix/pbs-docs-false-positives-43-20261031

Conversation

@patmmccann

Copy link
Copy Markdown
Collaborator

Summary

Resolve all 43 entries in the Docs say Prebid Server (pbs: true), but neither PBS Go nor PBS Java has the bidder category of the product-sync report.

  • 37 absent in both PBS Go and Java: set pbs: false, leaving PBJS support unchanged. Where pbs_app_supported: true was present, set it to false as well, to avoid contradictory app support claims.
  • Six case-only mismatches: preserve pbs: true and align PBS-specific names. PBS-only AdView → adview, progX → progx in biddercode; dual-platform SMB, defineMedia, interactiveOffers, nextMillennium retain their PBJS biddercode and gain an explicit pbs_biddercode with the lowercase canonical PBS name.

This avoids silently breaking client-side bidder codes or download-module names. Note: the new pbs_biddercode metadata is interpreted by the sync report in PR #6910, whose checker has been updated to honor it. Merge #6910 before/alongside this PR to clear the four dual-platform case warnings.

No adapters are deleted and no enable_download settings are changed. All changes are front matter except a short clarifying note for SMB and AdView.

Verification

Checked the changed docs against the original 43-item report, with case-only support kept distinct from unsupported code. CI pending.

@netlify

netlify Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit bcf1963
🔍 Latest deploy log https://app.netlify.com/projects/prebid-docs-preview/deploys/6ae63c92da6794ca2a19b47c
😎 Deploy Preview https://deploy-preview-6914--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T09:30:03.555495Z b6a30c8 PR opened
🔒 Security Review ✅ Completed 2026-10-31T09:24:22.524890Z b6a30c8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6a30c8359

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread dev-docs/bidders/avct.md Resolved
Comment thread dev-docs/bidders/xe.md Resolved
Comment thread dev-docs/bidders/gopl.md Resolved
Comment thread dev-docs/bidders/defineMedia.md Resolved
Comment thread dev-docs/bidders/vdoai.md Resolved
Comment thread dev-docs/bidders/cleanmedianet.md Resolved
@ChrisHuie

Copy link
Copy Markdown
Contributor

@patmmccann we would have to look at each of these in more detail. Looked at 3 and they were all unique. PBS or PBjs true also doesn't mean they are currently in master if that is the assumption? It's kind of like docs. We don't delete docs except on rare occasions because other versions/publishers could still be active. It means they were once in Prebid essentially... Don't care much about changing that assumption but that is how it is throughout the docs.

prebid/prebid-server-java#3096 - analytics adapter in server
prebid/prebid-server#4738 - approved and going in soon so would just have to flip right back

@ChrisHuie
ChrisHuie self-requested a review October 31, 2026 10:34
@patmmccann

patmmccann commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator Author

#5612 asks for these pages to sync to reality; it is trivial to flip them back and forth once #6910 is merged to keep in sync with reality.

Analytics adapters are not bidders

@ChrisHuie

ChrisHuie commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

@patmmccann nope but its less work then just dealing with it for a week or two. People tie their docs to PBjs and Prebid Server and JS merges much faster so assume there are a few where they set their docs to both and JS got merged and we missed the Server flag. We try to have them break them out or hold the merge up. Also, don't think there is another place where Analytics Adapters for server are listed actually? Could be wrong. So a larger question on breaking them out I would assume.

@ChrisHuie

ChrisHuie commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

thinking about it don't think PBS true controls the displaying under the bidder search? So maybe it doesn't matter.

**claude says it does control that. However, should it show up there probably not. Not sure how many other Analytics Adapters do that since there isn't an Analytics Adapters section like in JS. We could create one and just move the ones that use this flag that way?

@ChrisHuie
ChrisHuie requested review from muuki88 and removed request for ChrisHuie October 31, 2026 11:51
@ChrisHuie ChrisHuie removed the on hold label Oct 31, 2026
@patmmccann
patmmccann merged commit d2204e9 into master Oct 31, 2026
8 of 9 checks passed
@patmmccann
patmmccann deleted the fix/pbs-docs-false-positives-43-20261031 branch October 31, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants