Repository navigation
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
chanand
changed the title
The Prebid.js peak226 adapter (prebid/Prebid.js#15619) is now submitted, so this page covers both adapters instead of just Prebid Server: flips pbjs back to true, adds Prebid.js ad unit examples for banner, instream video and native, and splits the Notes section into per-adapter Prebid.js / Prebid Server subsections plus a shared Privacy note.
|
Updated to also cover the Prebid.js adapter (pbjs: true), now submitted at prebid/Prebid.js#15619. |
Following review feedback on prebid/Prebid.js#15619, the Prebid.js adapter no longer requires publisherId and placementId when the publisher already supplies {dooh|app|site}.publisher.id and ortb2Imp.tagid as first party data; the params act as per-ad-unit overrides. Prebid Server still requires both.
MD060 requires aligned-style table pipes; the required* cells were wider than the Scope column, throwing off alignment in rows 50-51.
|
The PBS notes say requests are split per region, but the adapter splits per region and |
|
Prebid.js 9 backport of the adapter: prebid/Prebid.js#15731 |
chanand
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cedda96ca6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Module Name: Peak226 Bidder Adapter | ||
| Module Type: Bidder Adapter |
There was a problem hiding this comment.
The bidder layout already renders Peak226 from the front-matter title and establishes that this is a bidder-adapter page, so the Module Name and Module Type lines duplicate metadata immediately before the content and create another copy to keep synchronized; retain only the maintainer contact if needed.
AGENTS.md reference: AGENTS.md:L11-L11
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Removed Module Name/Module Type; only Maintainer remains. 8c37d42
| adapter emits one outgoing request per distinct (region, `publisherId`) pair — each carrying | ||
| only its own impressions — rather than routing everything to the first impression's values. | ||
| Groups are requested in first-seen order. `publisherId` is written to `app.publisher.id` for |
There was a problem hiding this comment.
Publishers configure only region and publisherId; the per-pair batching mechanics and first-seen execution order are internal Prebid Server behavior that they cannot configure or safely rely on. Keep the user-facing routing constraint, but avoid making this vendor page mirror request-construction internals.
AGENTS.md reference: AGENTS.md:L12-L12
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Dropped the ordering and field-placement detail. The page now states only the user-facing constraint: requests are sent per distinct (region, publisherId). 8c37d42
| - **Multiformat impressions are supported.** Banner, video and native may be declared on the | ||
| same impression; all declared formats are forwarded and Peak226 may bid on any of them. No | ||
| format is dropped and there is no preferred-format selection. |
There was a problem hiding this comment.
The same multiformat guarantee is already stated in the Prebid.js notes and rendered from multiformat_supported, so this second three-line explanation gives maintainers multiple copies of the same claim to keep synchronized. State the shared behavior once and reserve the per-adapter sections for actual differences.
AGENTS.md reference: AGENTS.md:L10-L10
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Removed both multiformat bullets; the Features table (multiformat_supported: will-bid-on-any) is now the only statement. 8c37d42
|
|
||
| The Peak226 adapter connects Prebid.js and Prebid Server to the Peak226 SSP (Edge226 Ltd) for | ||
| **banner**, **video** and **native** demand. It speaks OpenRTB 2.6 and forwards standard | ||
| signals — first-party data, price floors, `user.eids`, supply chain (`schain`), deals |
There was a problem hiding this comment.
When this page is rendered, _includes/dev-docs/bidder-meta-data.html:63-64 maps the missing userIds front-matter value to none, while this sentence advertises that user.eids are forwarded. Publishers consulting the Features table therefore get the opposite answer from the description; add userIds: all (or the exact supported module list), or remove/rephrase the EID-support claim.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Added userIds: all. Both adapters forward user.eids unmodified (Prebid.js default ortbConverter; PBS passes user.eids through). 8c37d42
Drop Module Name/Type and duplicated multiformat text, reduce request-splitting notes to the user-facing constraint, and declare userIds: all so the Features table matches the documented EID forwarding.
|
Both points were fixed in ae03de9: the PBS notes now say requests are split per region and |
This branch has not been deployed
2 participants
Peak226: document the Prebid.js and Prebid Server adapters
This rewrites the existing
dev-docs/bidders/peak226.md, a 2018 stub left behind when theoriginal Peak226 Prebid.js adapter was removed in Prebid.js 3.0. The stub still declared a
uidparam that no longer exists.
The page now documents both new adapters:
publisherId/placementId/regionparams,banner + video + native (site and app), per-region/per-publisher request splitting,
${AUCTION_PRICE}expansion, the nativeadm_nativefallback, Prebid.js ad-unit examples, and thecapability front-matter (
pbjs: true,pbs: true).Related PRs (both merged)
Peak226 Bid Adapter: initial releaseNew Adapter: Peak226Notable declarations
dchain_supported: false— the adapter does not populate demand chain.ortb_blocking_supported: trueanddeals_supported: true—bcat/badv/bapp,battrandimp.pmpare forwarded to the endpoint.publisherId/placementIdare optional overrides ofortb2publisher id andortb2Imp.tagid/ortb2Imp.ext.gpid; on Prebid Server both are required.usesCookies: falseand omits Purpose 1, so aTCF-compliant CMP cannot authorize a cookie drop. Bidding is unaffected (Purpose 2 declared).