Repository navigation
feat: Warn on deeply nested illegal HTML structures in debug - #5358
Merged
Merged
Conversation
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
rschristian
marked this pull request as draft
November 12, 2026 03:50
|
Size Change: +10 B (+0.06%) Total Size: 16.3 kB 📦 View Changed
ℹ️ View Unchanged
|
|
coverage: 99.858%. remained the same — feat/deeply-nested-debug-warnings into main |
rschristian
marked this pull request as ready for review
November 12, 2026 03:53
JoviDeCroock
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this at work, someone accidentally had a
<button>, a whole lotta layers, and then another<button>.preact/debugwasn't throwing an console errors as we were only looking at direct children. CC @maybebotRecursively looking at children like this always feels a bit iffy, but most anchors, buttons, and paragraphs should be incredibly shallow trees, so it shouldn't' be problematic I don't think.
+ a drive-by swap from our "illegal child" regex to a set. Easier to read, should perform better? Happy to revert, it's obvs not related. Just caught my eye.