Repository navigation
Accept CSS color formats supported by plotly.js in the color validator - #5868
Open
ShawnNotFound wants to merge 2 commits into
Open
ShawnNotFound wants to merge 2 commits into
ShawnNotFound wants to merge 2 commits into
Conversation
Allow signed and exponent numbers, angle units other than deg, the none keyword, any color() color space and the transparent keyword. These are all accepted by plotly.js 4 but were rejected by the Python validator.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #5867
Description of change
The color validator now accepts the CSS color syntax that plotly.js parses: signed and exponent numbers, angle units other than
deg, thenonekeyword, anycolor()color space, andtransparent. Before, values likelab(50% -40 59.5)orcolor(srgb 1 0 0)raised aValueErroreven though plotly.js renders them.Demo
Testing strategy
Added valid and invalid cases to
test_color_validator.py. I checked each of them against culori, the parser plotly.js uses, so the validator accepts and rejects the same strings.Additional information (optional)
The old code removed spaces before matching so the regex didn't have to handle them. The new regex handles whitespace itself, so that step is gone. Strings that don't form a valid color function, like
rgb(255, 0)orrgb(1-2 3 4), are still rejected.Guidelines