Allow valid built-in constants in function parameters - #6579
Open
midhunmonachan wants to merge 1 commit into
Open
midhunmonachan wants to merge 1 commit into
midhunmonachan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback check for built-in constants used the parameter type alone. This made valid numeric constants such as
PHP_INT_SIZEfail when passed tostr_pad()because the function also has a flag parameter of typeint.The check now reports a constant only when it is listed for one of the function parameters that accepts constants. The regression test keeps the error for a misplaced
STR_PAD_LEFTflag.Closes phpstan/phpstan#15308
Checks:
bin/phpstan -vThe current
2.3.xbase also has pre-existing CI failures: the Turbo Extension Version Check after commit17972fe, and PHPStan on Windows with PHP 8.1 reaching its configured 599M memory limit inshipmonk/dead-code-detector. This PR does not touchturbo-extor that analysis path.