Repository navigation
PCSM-311: Document target write concern in PCSM 1.1.0 - #88
Closed
rasika-chivate wants to merge 2 commits into
Closed
rasika-chivate wants to merge 2 commits into
rasika-chivate wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation is consistent across all configuration surfaces and clearly describes operational risks.
0 open findings
What changed in this PR
Documents configurable target write concern support introduced in PCSM 1.1.0.
Changes:
- Documents CLI, API, and environment-variable configuration.
- Explains defaults, validation, persistence, and rollback risks.
- Connects the setting to HA recovery and operational guidance.
| File | Description |
|---|---|
docs/install/usage.md |
Adds comprehensive configuration and safety guidance. |
docs/pcsm-commands.md |
Documents the new start flag. |
docs/install/parameters.md |
Documents the environment variable. |
docs/api.md |
Documents the /start request field. |
docs/high-availability.md |
Explains persistence and rollback implications during takeover. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rasika-chivate
temporarily deployed
to
PCSM-311-target-write-concern-docs - pcsm-docs PR #88
October 9, 2026 08:41 — with
Render
Destroyed
nastena1606
temporarily deployed
to
PCSM-311-target-write-concern-docs - plm-docs PR #88
October 9, 2026 08:41 — with
Render
Destroyed
rasika-chivate
changed the base branch from
main
to
PCSM-382-skip-presplit-docs
October 9, 2026 08:41
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by draft PR #89, which uses
PCSM-311-PCSM-382-docsand targets PR #87's branch. All documentation content is preserved in the replacement. This PR's description, commits, and review remain available for reference.PCSM 1.1.0 lets users choose the write concern for target data writes during the initial clone and ongoing replication. This documents the three configuration methods, the default and supported values, and the recovery tradeoff when using a lower write concern. Checkpoints, HA state, and catalog changes continue to use majority.
Sources: PCSM-311, developer documentation notes, merged implementation PR #284, and its README.
The documentation release 1.1.0 comes from the ticket's Fix versions field. Jira marks that release as unreleased; this PR prepares documentation for it.
This PR depends on PR #87 and targets
PCSM-382-skip-presplit-docs. Merge #87 first, then retarget this PR tomain. The branch includes #87's changes, and the diff against that base contains only the target write concern documentation.Placement and changed files
docs/install/usage.md: adds Start the replication > Configure target write concern, including CLI, HTTP API, and environment-variable examples, rollback warning, run persistence, and operational cross-references.docs/pcsm-commands.md: adds--target-write-concernto thestartflags.docs/install/parameters.md: addsPCSM_TARGET_WRITE_CONCERNand makes clear that onlypcsm startconsumes it.docs/api.md: adds the string-valuedtargetWriteConcernfield toPOST /start.docs/high-availability.md: links the retained run setting and rollback risk from Checkpoint recovery.The existing pages are already in
mkdocs-base.yml. The new usage subsection appears in the rendered page TOC; no navigation file change is needed. Release notes are maintained separately in PR #85.Validation
PCSM-382-skip-presplit-docs(07daa53). Rebuilt the combined documentation successfully after stacking the branches.git diff --checkpassed.docs/about-docs.mdlinks to missingreference/contributing.md; left unchanged.Claim-to-source map
main.go(newStartCmd,resolveStartOptions,startRequest),config/config.go(bindEnvVars),cli_write_concern_test.go(TestStartTargetWriteConcernPrecedence)config/write_concern.go(ParseTargetWriteConcern),config/write_concern_test.go, CLI/API validation tests; developer comment Docs Notespcsm/pcsm.go(Checkpoint,Recover,Start)pcsm/clone/clone.go(NewClone),pcsm/repl/repl.go(NewRepl)docs/oplog-sizing.mddocs/install/usage.md, Target collections are overwritten on start warningNo claims of adjustable write concern on resume are included. PCSM-395 tracks that separate, open improvement.