Skip to content

fixing overhanging recommended text in onboarding - #218

Merged
cryppadotta merged 1 commit into
paperclipai:masterfrom
richardanaya:fix-recommended-pill
Mar 7, 2026
Merged

cryppadotta merged 1 commit into
paperclipai:masterfrom
richardanaya:fix-recommended-pill

Conversation

@richardanaya

@richardanaya richardanaya commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Before:

image

After:

image

@richardanaya
richardanaya force-pushed the fix-recommended-pill branch from 6b4ed81 to ee393ad Compare March 7, 2026 15:46
@greptile-apps

greptile-apps Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a minor UI layout issue in the onboarding wizard where the "Recommended" badge on adapter option buttons was overhanging outside the right edge of its parent container. The fix changes the Tailwind positioning utility from -right-1.5 (which pushed the badge 6px outside the button's right edge) to right-1 (which positions it 4px inside the right edge), keeping the badge visually contained within the button.

  • Changed file: ui/src/components/OnboardingWizard.tsx (line 733)
  • Change: Tailwind class on the Recommended badge updated from absolute -top-1.5 -right-1.5 to absolute -top-1.5 right-1
  • No logic, state, or behavioral changes — purely a CSS positioning fix
  • No issues found — the change is minimal, targeted, and correct

Confidence Score: 5/5

  • This PR is safe to merge — it is a one-line CSS positioning fix with no logic or behavioral changes.
  • The change is limited to a single Tailwind utility class on a decorative badge span. It has no impact on application logic, state management, or data flow. The fix correctly addresses the visual overflow described in the PR.
  • No files require special attention.

Important Files Changed

Filename Overview
ui/src/components/OnboardingWizard.tsx Single Tailwind CSS class change on the "Recommended" badge: -right-1.5right-1, preventing horizontal overflow outside the parent button's boundary.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Render adapter option button\nclassName includes 'relative'] --> B{opt.recommended?}
    B -- Yes --> C[Render 'Recommended' badge\nabsolute -top-1.5 right-1\nContained within button boundary]
    B -- No --> D[No badge rendered]
    C --> E[Render opt.icon]
    D --> E
    E --> F[Render opt.label]
    F --> G[Render opt.desc or 'Coming soon']
Loading

Last reviewed commit: ee393ad

@richardanaya
richardanaya force-pushed the fix-recommended-pill branch from ee393ad to ddb7101 Compare March 7, 2026 15:47
@cryppadotta
cryppadotta merged commit e07646b into paperclipai:master Mar 7, 2026
1 of 2 checks passed
@aaaaron

aaaaron commented Mar 7, 2026

Copy link
Copy Markdown
Collaborator

I like the screenshots

tmartin2113 pushed a commit to tmartin2113/paperclip that referenced this pull request Mar 15, 2026
…pill

fixing overhanging recommended text in onboarding
nydamon added a commit to nydamon/paperclip-1 that referenced this pull request Apr 9, 2026
…rements (paperclipai#218)

* feat(governance): add route guard standards, multi-role QA, and auth PR requirements

Engineering hardening across three layers — prevention, detection, enforcement —
to catch auth/routing bugs before they ship.

Prevention (thinking):
- H1: Route access matrix standard — every web project must maintain a
  living docs/route-access-matrix.md mapping routes to roles/guards/sidebar
- H5: Route guard rules — default-open policy, sidebar must match guards,
  core product pages never admin-gated

Detection (testing):
- H2: Role-matrix Playwright smoke test requirement for all web apps
- H3: Onboarding/critical-path smoke test requirement
- Definition of Done items 8-9 for auth/routing changes

Enforcement (process):
- H4: PR template section requiring route access matrix update and role
  test table for any PR touching auth/routing/sidebar
- H6: QA must test as BOTH admin AND member — single-role test is
  automatic FAIL, with hard rejection rules and evidence format

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: resolve merge conflicts in hardening standards

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: revert accidental retrigger limit change from stash conflict

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
p4w4n pushed a commit to p4w4n/paperclip that referenced this pull request May 8, 2026
…pill

fixing overhanging recommended text in onboarding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants