Repository navigation
[rejected AI] Fix urlencode treating UserDict keys as query pairs - #2276
Closed
jaideeppyne wants to merge 1 commit into
Closed
jaideeppyne wants to merge 1 commit into
jaideeppyne wants to merge 1 commit into
Conversation
urlencode only called .items() for dict, so Mapping types such as UserDict and MappingProxyType were iterated as keys. String keys then unpacked into (character, character) pairs and produced a corrupted query string. Fixes pallets#2269
jaideeppyne
force-pushed
the
fix-urlencode-mapping
branch
from
September 16, 2026 09:08
3092995 to
ce66d7d
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urlencodeonly called.items()fordict, so mapping types such asUserDictandMappingProxyTypewere iterated as keys. String keys then unpacked into(character, character)pairs and produced a corrupted query string.Fixes #2269