Repository navigation
api: env variable should override config file - #504
Merged
Merged
Conversation
The docker compose run was not working because it was picking up the config file mounted on the container, and the environment variables were never picked up. This commit ensure that if an environment variable is set, it always overrides what was previously found in the config.txt file. That change is done for the api and the meilisearch tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docker compose run was not working because
it was picking up the config file mounted on the
container, and the environment variables were never picked up.
This commit ensure that if an environment variable is set, it always overrides what was previously found in the config.txt file.
That change is done for the api and the meilisearch tooling.