Skip to content

golang: add 1.27 - #30368

Merged
GeorgeSapkin merged 6 commits into
openwrt:openwrt-25.12from
GeorgeSapkin:25.12/golang-add-1.27
Sep 30, 2026
Merged

GeorgeSapkin merged 6 commits into
openwrt:openwrt-25.12from
GeorgeSapkin:25.12/golang-add-1.27

Conversation

@GeorgeSapkin

@GeorgeSapkin GeorgeSapkin commented Aug 24, 2026 •

Copy link
Copy Markdown
Member

Maintainer: me

Description:

Backport to 25.12:

Don't build target packages and remove unnecessary test scripts.

[allow cherry-pick]


🧪 Run Testing Details

  • OpenWrt Version: 25.12.5
  • OpenWrt Target/Subtarget: x86/64
  • OpenWrt Device: QEMU

Tested building and running Syncthing.


✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.Fixes: a6e9444 ("golang: fix missing dependency check")

@openwrt openwrt Bot added Add package release/25.12 Issues/PR on branch 25.12 labels Aug 24, 2026
openwrt-ai

This comment was marked as resolved.

@GeorgeSapkin
GeorgeSapkin marked this pull request as ready for review September 3, 2026 21:22
openwrt-ai

This comment was marked as resolved.

@BKPepe
BKPepe requested a balanced review from Copilot September 5, 2026 20:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Adds a Go 1.27 package definition (host-only) to the OpenWrt packages feed and updates shared Go packaging helpers to support the new series.

Changes:

  • Introduce golang1.27 package Makefile and associated smoke/version test scripts.
  • Adjust shared Go packaging helpers (golang-version.mk) for stripping helper invocation and host-only packaging metadata.
  • Fix -tests extra provides list formatting in golang-version.mk.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
lang/golang/golang1.27/Makefile Adds the new Go 1.27 host package definition and build metadata.
lang/golang/golang1.27/test.sh Adds a basic “hello world” runtime smoke test for Go 1.27 packages.
lang/golang/golang1.27/test-version.sh Adds a version assertion test for Go 1.27 packages.
lang/golang/golang-version.mk Updates shared Go packaging logic (strip helper path, host-only flag, extra_provides formatting).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.


# Don't strip ELF executables in test data
RSTRIP:=$(subst $(SCRIPT_DIR)/rstrip.sh,go-strip-helper $(SCRIPT_DIR)/rstrip.sh,$(RSTRIP))
RSTRIP:=$(subst $(SCRIPT_DIR)/rstrip.sh,../go-strip-helper $(SCRIPT_DIR)/rstrip.sh,$(RSTRIP))
Comment thread lang/golang/golang1.27/test.sh Outdated
Comment thread lang/golang/golang1.27/test.sh Outdated
Comment thread lang/golang/golang1.27/test-version.sh Outdated
@niklasthorild

Copy link
Copy Markdown
Contributor

#30646 requires this to be merged into 25.12

Fixes: a6e9444 ("golang: fix missing dependency check")
Signed-off-by: George Sapkin <george@sapk.in>
(cherry picked from commit d2a4964)
Fix stripping when using previous version as a bootstrap.

Fixes: 5657eb0 ("golang: split src into separate packages")
Signed-off-by: George Sapkin <george@sapk.in>
(cherry picked from commit 591422e)
Add Go 1.27 and use the default bootstrap.

Changes: https://go.dev/doc/go1.27
Signed-off-by: George Sapkin <george@sapk.in>
(cherry picked from commit 57b8455)
Support configuring major version series as host-only (i.e. no target
packages) to reduce strain on buildbots in release branches. The goal is to
have one major target series and multiple host-only ones. E.g. 25.12 uses
1.26 as the default host/target series and 1.27 and beyond as host-only for
packages that require these.

Signed-off-by: George Sapkin <george@sapk.in>
(cherry picked from commit 4335f00)
Changes: https://github.com/golang/go/issues?q=milestone%3AGo1.27.1+label%3ACherryPickApproved
Signed-off-by: George Sapkin <george@sapk.in>
(cherry picked from commit 126203c)
Don't build target packages and remove unnecessary test scripts.

Signed-off-by: George Sapkin <george@sapk.in>
@GeorgeSapkin
GeorgeSapkin merged commit 92bc644 into openwrt:openwrt-25.12 Sep 30, 2026
14 checks passed
@GeorgeSapkin
GeorgeSapkin deleted the 25.12/golang-add-1.27 branch September 30, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Add package release/25.12 Issues/PR on branch 25.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants