[knutwannheden]

Five recipes replace a method declaration's return type expression but leave its JavaType.Method returning the old type. A FindMissingTypes check proposed in openrewrite/rewrite#9284 compares the two on every RewriteTest output. Against that branch, 10 tests in BeanMethodReturnNullTest, PreciseBeanTypeTest, MigrateAuditorAwareToOptionalTest, MigrateJobParameterTest and MigrateWebMvcConfigurerAdapterTest fail like this:

BeanMethodReturnNullTest > transformReturnType() FAILED
    java.lang.IllegalStateException: LST contains missing or invalid type information
    /*~~(MethodDeclaration#returnTypeExpression type does not match the return type of the MethodType)~~>*/@Bean
    public Object myBean() {

A new helper, MethodDeclarations.withReturnTypeExpression(md, typeTree) in org.openrewrite.java.spring.internal, replaces the expression and updates the method type's return type to match. All eight call sites in the five recipes now use it:

md = withReturnTypeExpression(md, TypeTree.build("Object").withType(...));

The declaration and its name get the same updated JavaType.Method instance, because FindMissingTypes also checks that the name's type is the declaration's method type. The helper uses only API that is already released, so these recipes can be fixed before #9284 merges.

PreciseBeanType's array branch narrowed only the text

For List[] bean1() { return new ArrayList[0]; } the array branch had two bugs:

• It replaced the element's name but gave the element the array type and left the J.ArrayType typed List[]. The method kept returning List[], so the recipe ran a second cycle. The new check misses this because the expression and the method type are equally stale.
• Its import-removal guard tested the element TypeTree instead of the element's type, so import java.util.List was never removed.

The new test PreciseBeanTypeTest.arrayType covers both bugs. It failed with "took 2 cycles" before the fix. I confirmed it catches the import bug by putting the old guard back temporarily. The 10 existing tests above pass against #9284 with this change, and all tests in the five classes pass against the published snapshot.