Repository navigation
Map EE9 Jetty security and WebSocket artifacts to published Jetty 12 modules - #1311
Merged
Merged
Conversation
…ty 12 core modules in JettyUpgradeEE10
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JettyUpgradeEE10mapped three EE9 artifacts to EE10 coordinates that have no Jetty 12 release on Maven Central. Every project using them ended up with an unresolvable POM.newVersion: 12.0.x.Problem
org.eclipse.jetty.ee9:jetty-ee9-securityorg.eclipse.jetty.ee10:jetty-ee10-securityorg.eclipse.jetty.ee9.websocket:jetty-ee9-websocket-jetty-apiorg.eclipse.jetty.ee10.websocket:jetty-ee10-websocket-jetty-api12.0.0.alpha0..12.0.0.beta0onlyorg.eclipse.jetty.ee9.websocket:jetty-ee9-websocket-jetty-clientorg.eclipse.jetty.ee10.websocket:jetty-ee10-websocket-jetty-client12.0.0.alpha0..12.0.0.beta2onlyBefore this change, the new test produced:
jetty-ee10-security failed. Unable to download metadata ... HTTP 404, withjetty-ee9-securityleft in place.Unable to download POM: ...jetty-ee10-websocket-jetty-api:12.0.x(and the same for-client). Both dependencies were rewritten with the literal12.0.x, because no matching release exists.Solution
jetty-ee9-security→org.eclipse.jetty:jetty-securityjetty-ee9-websocket-jetty-api→org.eclipse.jetty.websocket:jetty-websocket-jetty-apijetty-ee9-websocket-jetty-client→org.eclipse.jetty.websocket:jetty-websocket-jetty-clientThese were found in a catalog-wide check of dependency-swap steps against Maven Central metadata.
Not addressed here:
JettyUpgradeEE10changes dependencies but not the matchingorg.eclipse.jetty.ee9.*→org.eclipse.jetty.ee10.*Java packages, apart from oneChangeType.Test plan
JettyUpgradeEE10Testfails before the change and passes afterJettyUpgradeEE9TestandJakartaEE10Testpass