Repository navigation
Keep method type in sync with migrated return type in MigratePoolingNHttpClientConnectionManager - #157
Merged
Conversation
…HttpClientConnectionManager Changing a method declaration's return type expression left its JavaType.Method returning the old type. Update the method type, and the name's type with the same instance, alongside the return type expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openrewrite/rewrite#9284 adds a
FindMissingTypescheck thatRewriteTestruns on every recipe's output. With it,MigratePoolingNHttpClientConnectionManagerTest.migratesSimpleConstructorandmigratesWhenPassedAsArgumentsfail:The recipe rewrites a method's return type expression from
PoolingNHttpClientConnectionManagertoPoolingAsyncClientConnectionManagerbut leaves the declaration'sJavaType.Methodreturning the 4.x type, so any later recipe reading the method type still sees the old class.The fix updates the method type's return type together with the expression, and gives the method name that same
JavaType.Methodinstance, which anotherFindMissingTypescheck requires. It uses only API in released rewrite, so it can merge ahead of #9284. The existing tests catch the bug once #9284 is in, and they pass both with and without it after this change.