Skip to content

fix JAR fallback text - #798

Merged
brentzundel merged 1 commit into
mainfrom
779-may-jar
Sep 24, 2026
Merged

brentzundel merged 1 commit into
mainfrom
779-may-jar

Conversation

@c2bo

@c2bo c2bo commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Fixes #779

Added it to the 1.0 errata as well

@brentzundel
brentzundel requested review from awoie and jogu September 17, 2026 15:11
@brentzundel

Copy link
Copy Markdown
Collaborator

Discussed to day. @jogu and @awoie will review

@jogu jogu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a little bit of a breaking change around treating unknown values as GET that's a little bit dicey (in terms of whether we can included it in the conformance tests for wallets that are following 1.0 without errata) but overall I think it's probably best to make the change.

@awoie awoie left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the change could be considered breaking. However, it is probably what wallets have implemented already, so it should be fine.

@brentzundel

Copy link
Copy Markdown
Collaborator

Sufficient review time, approved, no requests for changes, merging

@brentzundel
brentzundel merged commit 8768911 into main Sep 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Wallet MAY continue with JAR" is contradicted later in the spec and intended to be a MUST

5 participants