Repository navigation
Clamp Shape slice bounds before eliminating Shape - #351
Merged
Merged
Conversation
Signed-off-by: Yuhx141 <155034285+Yuhx141@users.noreply.github.com>
Yuhx141
force-pushed
the
fix-shape-slice-bounds
branch
from
October 1, 2026 04:59
8a6d064 to
591407f
Compare
Signed-off-by: Yuhx141 <155034285+Yuhx141@users.noreply.github.com>
take-cheeze
reviewed
Oct 1, 2026
Signed-off-by: Yuhx141 <155034285+Yuhx141@users.noreply.github.com>
Contributor
Author
|
The unrelated sequence-test change remains removed from this Shape fix. I moved the self-contained replacement to #355, where it can be reviewed and tested independently. |
take-cheeze
enabled auto-merge (squash)
October 2, 2026 10:13
take-cheeze
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clamp normalized Shape start/end attributes to the input rank in the shared range helper. This preserves ONNX slicing semantics for bounds outside the rank and prevents eliminate_shape_op from advancing past the stored dimensions.
For a rank-2 input, Shape(start=5) should produce an empty int64[0] tensor. Before this change, the pass computes sizes.cbegin() + 5; an ASan run through onnxsim.simplify reports a heap-buffer-overflow in eliminate_shape_op.h.
Changes
Validation
Related: onnxsim/onnxsim#2015