fix: label document notifications and activities - #169
Open
lollipop-onl wants to merge 3 commits into
Open
lollipop-onl wants to merge 3 commits into
lollipop-onl wants to merge 3 commits into
Conversation
Backlog reuses notification reasons 14-18 and adds activity types 36-49 for the document feature, but bee still mapped 14-17 to mention reasons that the API no longer defines. `bee notification list` therefore showed the wrong reason for every document notification, and the activity commands fell back to "Type N" for document events. The labels follow the Japanese API reference, which also lists reasons 16 and 18 (bulk-added issues) that the English page omits. Types 34, 35 and 47 are kept even though neither page lists them, since they come back in real activity data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Backlog's internal ActivityType also defines 50 and 51 for adding and removing related issues, and the API returns them from the activity endpoints, but the public API reference does not list them yet, so they still showed as "Type 50" / "Type 51". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the document activity types labelled, `bee project activities` and friends showed "Document Created" next to an empty summary, because getActivitySummary only knew issue-shaped content. Document activities carry `title` (or `documents[].title` for bulk creation), which a live space confirmed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the notification reason and activity type labels for Backlog's document feature.
bee notification listshowed the wrong reason for every document notification. They now read Document commented / Document comment replied / Document mentioned. 16 and 18 (issues bulk-added, assigned / notified) are added.bee project activities,bee space activitiesandbee user activitiesshowedType Nfor them.The labels follow the Japanese API reference, which lists reasons 16 and 18 that the English page omits. 50 and 51 are not in the public reference yet, but the activity endpoints return them. All values, including 34, 35 and 47 (not in the public reference either), were cross-checked against Backlog's internal definitions.
Document activities also get a summary now:
getActivitySummaryfalls back totitle(anddocuments[].titlefor bulk creation). Before, they showed an empty SUMMARY column once labelled.Test plan
vp checkpassesvp test: all tests passdocument, 16/18 have neither issue nor document);bee project activitiesshowsDocument Created <title>andRelated Issue Added🤖 Generated with Claude Code