Skip to content

fix(dav): apply stored additional properties to calendar rows - #66218

Open
SebastianKrupinski wants to merge 1 commit into
masterfrom
fix/calendar-additional-properties
Open

fix(dav): apply stored additional properties to calendar rows#66218
SebastianKrupinski wants to merge 1 commit into
masterfrom
fix/calendar-additional-properties

Conversation

@SebastianKrupinski

@SebastianKrupinski SebastianKrupinski commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Resolves: Client Issue
  • Calendar properties stored in oc_properties were only applied while answering PROPFIND, so consumers that read calendar data directly, such as the free/busy lookup, never saw them.
  • Modified CalDavBackend to also apply custom properties so the properties are available in all calendars

Testing

  • This fixes free/busy in shared calendars. To test create some blocking events in a shared calendar and inspect the free busy

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@SebastianKrupinski SebastianKrupinski added this to the Nextcloud 36 milestone Nov 3, 2026
@SebastianKrupinski SebastianKrupinski self-assigned this Nov 3, 2026
@SebastianKrupinski SebastianKrupinski added the 2. developing Work in progress label Nov 3, 2026
@SebastianKrupinski
SebastianKrupinski requested a review from a team as a code owner November 3, 2026 17:41
@SebastianKrupinski
SebastianKrupinski requested review from icewind1991 and removed request for a team November 3, 2026 17:41
@github-project-automation github-project-automation Bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Nov 3, 2026
@SebastianKrupinski
SebastianKrupinski marked this pull request as draft November 3, 2026 17:41
Copilot stopped work on behalf of SebastianKrupinski due to an error November 10, 2026 16:52
The session was cancelled by the user.
@SebastianKrupinski
SebastianKrupinski force-pushed the fix/calendar-additional-properties branch from 2311d00 to 06db779 Compare November 10, 2026 18:07
@SebastianKrupinski
SebastianKrupinski marked this pull request as ready for review November 10, 2026 19:49
@SebastianKrupinski SebastianKrupinski added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 10, 2026
@SebastianKrupinski
fix(dav): apply stored additional properties to calendar rows
2384279 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@SebastianKrupinski
SebastianKrupinski force-pushed the fix/calendar-additional-properties branch from 06db779 to 2384279 Compare November 10, 2026 23:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner
@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend
@kesselb kesselb Awaiting requested review from kesselb
@DerDreschner DerDreschner Awaiting requested review from DerDreschner
@hamza221 hamza221 Awaiting requested review from hamza221
@odzhychko odzhychko Awaiting requested review from odzhychko

At least 2 approving reviews are required to merge this pull request.

Assignees

@SebastianKrupinski SebastianKrupinski

Labels

3. to review Waiting for reviews AI assisted

Projects

💌 📅 👥 Groupware team
Status: 🏗️ In progress

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

2 participants

@SebastianKrupinski @nextcloud-command