Skip to content

Fix wrapped supported/advertising fields in mikrotik_routeros_interface_ethernet_monitor_name_once - #2358

Open
k-ribot wants to merge 1 commit into
networktocode:masterfrom
unyc-io:fix-mikrotik-corrected-interface-ethernet-monitor-template
Open

k-ribot wants to merge 1 commit into
networktocode:masterfrom
unyc-io:fix-mikrotik-corrected-interface-ethernet-monitor-template

Conversation

@k-ribot

@k-ribot k-ribot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • supported:, advertising: and link-partner-advertising: on Mikrotik
    RouterOS can wrap onto multiple bare-value lines instead of one comma
    separated line, when the terminal is too narrow. The template only handled
    the single-line case.
  • Converts these three fields to List values and adds dedicated FSM states
    so wrapped continuation lines are correctly captured into the right list.
  • Adds two new raw/yml test cases (5 and 6) reproducing the wrapped format.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@k-ribot
k-ribot force-pushed the fix-mikrotik-corrected-interface-ethernet-monitor-template branch from 019f190 to ff5e290 Compare September 4, 2026 12:59
@mjbear mjbear changed the title fix: Fix wrapped supported/advertising fields in mikrotik_routeros_interface_ethernet_monitor_name_once Fix wrapped supported/advertising fields in mikrotik_routeros_interface_ethernet_monitor_name_once Sep 8, 2026
@mjbear

mjbear commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

@k-ribot
What's the process like to accept code suggestions through the unyc GH organization?
Are you able to click accept on my suggestions to have them added to your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants