Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #105. Command-line
-Dand-Uoptions were collected separately and applied as all definitions followed by all undefinitions, losing their order. For example,-DFOO=1 -UFOO -DFOO=2leavesFOOundefined instead of expanding it to2.Record the operations as argparse processes them and replay them in order. Preserve the existing
args.definesandargs.undefineslists and definition parsing, including bare definitions and values containing=.-Nbehavior is unchanged.Verification
Tests use unittest and synthetic stdin/stdout, as required by AGENTS.md. On Windows and Python 3.12.10:
python -m unittest tests.issue0105 -v: 10 passed.alternate_input_encodings.pyUTF-16 input cases in this environment. They were not changed or hidden.python setup.py build: passed (existing setuptools deprecation warnings).git diff --check: passed.python setup.py testcannot run with installed setuptools 84 because its test command has been removed. Full CI/Python/platform matrix was not run locally.No changes were made inside the PLY submodule. AI assistance (OpenAI Codex) was used for investigation, implementation and testing; the minimal diff and before/after results were reviewed against current upstream master.