follow-up to NebariApp template adoption

[pmeier]

Reference Issues or PRs

Addresses the open comments in #32.

What does this implement/fix?

Put a x in the boxes that apply

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds a feature)
• Breaking change (fix or feature that would cause existing features not to work as expected)
• Documentation Update
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Other (please describe):

Testing

• Did you test the pull request locally?
• Did you add new tests?

Documentation

Access-centered content checklist

Text styling

• The content is written with plain language (where relevant).
• If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
• All links describe where they link to (for example, check the Nebari website).
• This content adheres to the Nebari style guides.

Non-text content

• All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
• If there are emojis, there are not more than three in a row.
• Don't use flashing GIFs or videos.
• If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

[github-actions]

📄 Docs preview for nebrari-app-template-followup:
https://nebrari-app-template-followu.nebari-software-pack-template.pages.dev

[dcmcand]

The Helm section now matches the real basic-nginx template and values, both doc copies move together, and the stale service.name: "" default is gone. Five suggestions inline, most one-click: the Makefile still fails at the kubectl wait step, the values snippet needs routing, and three smaller fixes.

Heads-up: #45 changes the same Makefile lines and Helm section, so whichever of these lands second will need a rebase.

[dcmcand]

build installs exactly what the committed Chart.lock pins, which is what CI and the docs use for this chart. update re-resolves >=0.1.1 and will rewrite the lock in the working tree once a newer nebari-app is published, so make up-basic would then test a different library version than CI.

Suggested change

	helm dependency update $(CHART_BASIC)
	helm dependency build $(CHART_BASIC)

This target still fails a few lines down. Line 159 waits on nebariapp/my-pack-my-pack, but the release name my-pack already contains the chart name, so the fullname helper renders the NebariApp as my-pack, and kubectl wait exits with NotFound. That line is outside the diff, so it can't be a suggestion; it should be:

	kubectl wait --for=condition=Ready nebariapp/my-pack --timeout=120s

up-fastapi (line 175) and up-podinfo (line 191) have the same wait.

[pmeier]

Both issues are pre-existing. I'll only fixing the helm dependency update part here, because this PR touches these lines already. The other issue is left for a follow-up PR.

[dcmcand]

Thanks, suggestions look good and both doc copies match. Agreed the kubectl wait nebariapp/my-pack-my-pack fix belongs in a follow-up since it's outside this diff. Could you open an issue for it so it doesn't get lost? Heads-up that #45 touches the same Makefile lines and Helm section, so whichever lands second will need a rebase.