Repository navigation
Conversation
github-actions
Bot
requested review from
SooKim1110,
acktsap,
benelog,
jwChung,
mhyeon-lee and
seongahjo
September 30, 2026 02:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayListfor each sample when aListvalue reaches the set-decomposition fast path.Reproduction
On
maind6e285af401f06a3934e2caddfdad052000276ce, both new tests fail: samples share the supplied list, and removing an item from a sample created fromArrays.asListthrowsUnsupportedOperationException. This addresses the List examples in #1348.Tests
./gradlew :fixture-monkey:test --tests com.navercorp.fixturemonkey.test.SetCollectionIsolationTest --no-daemon— 2/2 pass after the fix (2/2 failed before)../gradlew :fixture-monkey:test --no-daemon— 1,225/1,225 pass.Scope
The change covers List values whose declared type accepts
ArrayList. Other concrete List types and nested mutable elements are outside this patch.