Repository navigation
fix(highwind): log run failures that happen before the first log line - #625
Merged
jaredlockhart merged 2 commits intoNov 2, 2026
Merged
Conversation
Because * A run that failed before its first log statement wrote nothing to the run log, so a crash in discovery left no trace in BigQuery. This commit * Writes an ERROR row with the exception and flushes buffered rows before re-raising, on runs that write tables. * Adds tests for the failure row, the no-write runs and a failing log write. Tracked by [EXP-7916](https://mozilla-hub.atlassian.net/browse/EXP-7916).
mikewilli
approved these changes
Nov 2, 2026
| try: | ||
| yield run_log | ||
| except Exception: | ||
| logger.exception("the run failed and did not finish") |
There was a problem hiding this comment.
Would it be helpful to log any additional info about the run?
Contributor
Author
There was a problem hiding this comment.
Maybe, we can add more info later when fun new bugs crop up 🙏
jaredlockhart
enabled auto-merge (squash)
November 2, 2026 18:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
discovery left no trace in BigQuery.
This commit
that write tables.
Tracked by EXP-7916