Repository navigation
Conversation
Fixes mozilla#937 Signed-off-by: Don Yin <Don_Yin@outlook.com>
Signed-off-by: Don Yin <Don_Yin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #937.
With a field behind
#[cfg(feature = "...")], the generated C++operator==/operator!=still compared that field unconditionally, so the header failed to compile whenever the feature's define was off (use of undeclared identifier 'alloc_size'). The struct itself already wraps the field in#if, but the comparison didn't.For
==and!=, when any field has a cfg, I now emit each comparison inside its own#ifblock and end the expression with a neutraltrue/false, so it stays valid whichever fields are present. Structs without cfg'd fields produce the same output as before.I dropped the
FIXME(#634)derive-eq/neq opt-out on the existingConditionalFieldtest so it covers this, and updated the expectation.cargo test, fmt and clippy pass locally.