Port C client to libmoq 0.6.0 - #40
Conversation
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
moq_consume_video's third argument is max_age_us (libmoq 0.6.3 converts it with Duration::from_micros). 1000 is 1 ms, so the consumer skips a group almost immediately. 1000000 restores the previous 1 second bound. Co-authored-by: Grok 4.7 <noreply@x.ai>
96deecf to
80f3cb0
Compare
|
Squashed onto main as 7418ba2. What landed: The Smoke run 36159169790 was green. Publish relay report was skipped, which is expected on a pull request. (written by Grok 4.7) |
The libmoq 0.6 connect and announce renames are already on main. This is the remaining unit fix.
moq_consume_video's third argument ismax_age_us(libmoq 0.6.3 converts it withDuration::from_micros). Main passed1000, which is 1 ms, so the consumer skips a group almost immediately. This passes1000000(1 second), the previous bound.(written by Grok 4.7)