Skip to content

Port C client to libmoq 0.6.0 - #40

Merged
kixelated merged 1 commit into
mainfrom
claude/libmoq-0.6
Sep 25, 2026
Merged

kixelated merged 1 commit into
mainfrom
claude/libmoq-0.6

Conversation

@kixelated

@kixelated kixelated commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

The libmoq 0.6 connect and announce renames are already on main. This is the remaining unit fix.

moq_consume_video's third argument is max_age_us (libmoq 0.6.3 converts it with Duration::from_micros). Main passed 1000, which is 1 ms, so the consumer skips a group almost immediately. This passes 1000000 (1 second), the previous bound.

(written by Grok 4.7)

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c43f6c6b-5f34-4998-bc2c-b0255c5c58d5

📥 Commits

Reviewing files that changed from the base of the PR and between 08bac99 and 80f3cb0.

📒 Files selected for processing (1)
  • clients/c/subscribe.c

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T16:13:32.872350Z 80f3cb0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

moq_consume_video's third argument is max_age_us (libmoq 0.6.3 converts
it with Duration::from_micros). 1000 is 1 ms, so the consumer skips a
group almost immediately. 1000000 restores the previous 1 second bound.

Co-authored-by: Grok 4.7 <noreply@x.ai>
@kixelated
kixelated merged commit 7418ba2 into main Sep 25, 2026
8 checks passed

Copy link
Copy Markdown
Contributor Author

Squashed onto main as 7418ba2.

What landed: moq_consume_video now gets 1000000 (max_age_us, 1 second) instead of 1000 (1 ms). libmoq 0.6.3 converts that argument with Duration::from_micros.

The NULL connect config and moq_origin_announced_broadcast rename were already on main and are not in this commit.

Smoke run 36159169790 was green. Publish relay report was skipped, which is expected on a pull request.

(written by Grok 4.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant