Repository navigation
agentHost: preserve read-only session configuration values - #339328
Merged
Merged
Conversation
Stop enforcing readOnly when validating and forwarding session config so settings-derived worktree options survive discovery, creation, and refresh. Keep picker editability and the remaining schema checks unchanged. Add regression coverage for worktree options and update workbench payload expectations. Regression from #339034. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The generalized filter now leaks host-reported fields into replacement mutation payloads.
Review effort: Balanced
Findings: 1
What changed in this PR
Preserves host-advertised read-only session configuration while keeping UI editing disabled.
Changes:
- Allows read-only values through validation and forwarding.
- Refreshes settings-derived worktree configuration.
- Updates schemas, documentation, and regression expectations.
| File | Description |
|---|---|
sessionConfigProperties.ts |
Revises filtering and validation semantics. |
sessionConfigProperties.test.ts |
Covers read-only forwarding and picker editability. |
baseAgentHostSessionsProvider.ts |
Refreshes advertised settings-derived values. |
localAgentHostSessionsProvider.test.ts |
Expands worktree and read-only coverage. |
agentHostChatInputPicker.test.ts |
Updates refresh payload expectation. |
agentHostGenericConfigChips.test.ts |
Preserves read-only values in payloads. |
meta/README.md |
Documents read-only forwarding behavior. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverPluginsLoadingMore/Light
| Before | After |
|---|---|
 |
 |
1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
roblourens
marked this pull request as ready for review
October 2, 2026 17:58
roblourens
enabled auto-merge (squash)
October 2, 2026 17:58
Vritant Bhardwaj (vritant24)
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced by #339034: client-side schema filtering dropped settings-derived worktree configuration because the host marks these properties
readOnly. In particular,git.worktreeSymlinkFoldersstopped reaching the host, so folders such asnode_moduleswere no longer symlinked into new worktrees.readOnlyin session config validation/filtering and in the pre-send settings refresh. Pickers still honorreadOnlyfor UI editability; advertised-key, enum, and session-mutability checks remain unchanged.Validation
npm run compile-client— passed.git diff --check— passed.git.worktreeSymlinkFoldersto include an existing ignored folder such asnode_modules, create an Agent Host session using worktree isolation, and send its first request. Confirm the new worktree contains the expected symlink. Also verify that these host-owned properties do not become editable config chips.(Written by Copilot)