Skip to content

chat: Improve marketplace detail metadata and actions - #339162

Merged
Jessie Houghton (houghj16) merged 8 commits into
mainfrom
agents/customization-windows-badge-update
Oct 2, 2026
Merged

Jessie Houghton (houghj16) merged 8 commits into
mainfrom
agents/customization-windows-badge-update

Conversation

@houghj16

@houghj16 Jessie Houghton (houghj16) commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • show marketplace publisher or repository owner beside the detail title instead of the availability badge
  • enrich Agent Finder MCP entries with publisher metadata from the existing registry lookup
  • use Connect, Reconnect, and Disconnect actions for Copilot connector details
  • present publisher metadata as secondary text aligned with the title bottom edge
  • preserve missing, error, and unavailable states in compact MCP-style diagnostic banners with Repair and View Setup actions where applicable

Screenshots

State Dark Light
Missing Missing customization state in dark theme Missing customization state in light theme
Error Customization installation error in dark theme Customization installation error in light theme
Unavailable Unavailable customization state in dark theme Unavailable customization state in light theme

Testing

  • npm run compile — passed
  • .\scripts\test.bat --run src\vs\platform\agentFinder\test\common\agentFinderRestProvider.test.ts --run src\vs\workbench\contrib\chat\test\browser\aiCustomization\pluginCustomizationMarketplaceProvider.test.ts --run src\vs\workbench\contrib\chat\test\browser\aiCustomization\embeddedMarketplaceDetail.test.ts — 66 tests passed
  • Component Explorer missing/error/unavailable detail fixtures — 6 variants rendered without errors and remained stable across 3 captures
  • npm run typecheck-client — passed
  • git diff --check — passed

Show marketplace publishers beside item titles, reuse available provenance for plugin and MCP sources, and use connection-specific actions for Copilot connectors.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 1, 2026 19:05
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 03639228 Current: d3aac457

Changed (9)

sessions/accountMenu/WeeklyAndFiveHourLimits/Light
Before After
before after
sessions/accountMenu/WeeklyLimitOnly/Light
Before After
before after
sessions/accountMenu/FiveHourLimitOnly/Light
Before After
before after
sessions/accountMenu/UsageUnavailable/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverAvailableSearchResult/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverAvailableSearchResultNarrow/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverMcpDetail/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverPluginDetail/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverPluginsLoadingMore/Light
Before After
before after

1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Added (3)

chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverMissingDetail/Light

current

chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverInstallErrorDetail/Light

current

chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverUnavailableDetail/Light

current

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Publisher attribution, failure-state visibility, responsive layout, and accessibility help need correction.

Review effort: Balanced
Findings: 2 Medium severity · 2 Low severity

Open (4)
What changed in this PR

Improves customization marketplace details with publisher metadata and connector-specific actions.

Changes:

  • Adds publisher metadata from plugin and MCP registries.
  • Replaces availability badges with publisher text.
  • Adds Connect, Reconnect, and Disconnect actions.
File Description
agentFinderRestProvider.ts Enriches MCP metadata.
agentFinderRestProvider.test.ts Tests registry metadata lookup.
embeddedMarketplaceDetail.ts Updates metadata and connector actions.
aiCustomizationManagement.css Styles publisher text.
pluginCustomizationMarketplaceProvider.ts Derives plugin publishers.
embeddedMarketplaceDetail.test.ts Tests detail rendering and actions.
pluginCustomizationMarketplaceProvider.test.ts Tests publisher derivation.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Show missing, error, and unavailable details using the existing MCP diagnostic banner, route missing items through Repair, and address publisher attribution, truncation, and connector accessibility feedback.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Show missing, error, and unavailable marketplace details in Component Explorer and keep their diagnostic banners aligned and content-sized.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use trusted registry, repository owner, and connector destinations for publisher links in marketplace details.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve trusted MCP registry repository metadata and use its GitHub owner as the publisher destination when the registry has no publisher URL.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
Jessie Houghton (houghj16) marked this pull request as ready for review October 2, 2026 19:59
@houghj16
Jessie Houghton (houghj16) merged commit a775865 into main Oct 2, 2026
55 of 56 checks passed
@houghj16
Jessie Houghton (houghj16) deleted the agents/customization-windows-badge-update branch October 2, 2026 20:53
@vs-code-engineering vs-code-engineering Bot added this to the 1.141.0 milestone Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants