Skip to content

sessions: show remote name in session hovers - #338193

Merged
Benjamin Christopher Simmonds (benibenj) merged 2 commits into
mainfrom
benibenj/agents/sessions-hover-remote-name-display
Sep 27, 2026
Merged

Benjamin Christopher Simmonds (benibenj) merged 2 commits into
mainfrom
benibenj/agents/sessions-hover-remote-name-display

Conversation

@benibenj

Copy link
Copy Markdown
Contributor

Summary

  • show the remote host name after the session title and session type/provider in Agents Window session hovers
  • apply the same identity line to nested chat-row hovers for remote sessions
  • preserve existing local-session hover text and avoid duplicate provider/remote labels when a disconnected provider has no session-type metadata
  • add focused regression coverage for ordering, local sessions, and disconnected fallback behavior

Validation

Not run, per the requested rubber-duck-and-merge workflow. The change was reviewed with a rubber-duck pass before commit.

Include the remote host label after the session type in Agents Window session and chat-row hovers while leaving local hovers unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused implementation preserves existing behavior and includes appropriate regression coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Adds remote host identity to Agents Window session and nested chat hovers while preserving local and disconnected fallback behavior.

Changes:

  • Adds optional remote-host metadata to the shared hover widget.
  • Derives provider and remote labels for session/chat hovers.
  • Adds regression coverage for label ordering and fallback behavior.
File Description
sessionSummaryHover.ts Renders the remote host after the provider label.
sessionHoverContent.ts Derives provider and remote-host hover metadata.
sessionsList.test.ts Tests remote, local, and disconnected label behavior.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Use explicitly typed session types and a generic provider-service test double so Compile & Hygiene can typecheck the remote hover coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@benibenj
Benjamin Christopher Simmonds (benibenj) merged commit 682c0f7 into main Sep 27, 2026
35 checks passed
@benibenj
Benjamin Christopher Simmonds (benibenj) deleted the benibenj/agents/sessions-hover-remote-name-display branch September 27, 2026 12:49
@vs-code-engineering vs-code-engineering Bot added this to the 1.140.0 milestone Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants