sessions: show remote name in session hovers - #338193
Merged
Benjamin Christopher Simmonds (benibenj) merged 2 commits intoSep 27, 2026
Merged
Benjamin Christopher Simmonds (benibenj) merged 2 commits into
Benjamin Christopher Simmonds (benibenj) merged 2 commits into
Conversation
Include the remote host label after the session type in Agents Window session and chat-row hovers while leaving local hovers unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
September 27, 2026 12:21
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
September 27, 2026 12:22
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation preserves existing behavior and includes appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Adds remote host identity to Agents Window session and nested chat hovers while preserving local and disconnected fallback behavior.
Changes:
- Adds optional remote-host metadata to the shared hover widget.
- Derives provider and remote labels for session/chat hovers.
- Adds regression coverage for label ordering and fallback behavior.
| File | Description |
|---|---|
sessionSummaryHover.ts |
Renders the remote host after the provider label. |
sessionHoverContent.ts |
Derives provider and remote-host hover metadata. |
sessionsList.test.ts |
Tests remote, local, and disconnected label behavior. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Use explicitly typed session types and a generic provider-service test double so Compile & Hygiene can typecheck the remote hover coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ladislau Szomoru (lszomoru)
approved these changes
Sep 27, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 27, 2026
682c0f7
into
main
35 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/agents/sessions-hover-remote-name-display
branch
September 27, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Not run, per the requested rubber-duck-and-merge workflow. The change was reviewed with a rubber-duck pass before commit.