chore(0.84): prepare stable 0.84.0 with React Native 0.84.1

.changeset/config.json

@@ -1,12 +1,12 @@
 {
   "$schema": "https://unpkg.com/@changesets/config@3.1.1/schema.json",
   "access": "public",
-  "baseBranch": "origin/main",
+  "baseBranch": "origin/0.84-stable",
   "bumpVersionsWithWorkspaceProtocolOnly": true,
   "changelog": "@changesets/cli/changelog",
   "commit": false,
   "fixed": [["react-native-macos", "@react-native-macos/virtualized-lists"]],
-  "ignore": ["react-native-macos", "@react-native/tester"],
+  "ignore": [],
   "privatePackages": {
     "version": false,
     "tag": false

.github/actions/build-android/action.yml

@@ -16,10 +16,17 @@ runs:
       uses: ./.github/actions/setup-node
     - name: Install node dependencies
       uses: ./.github/actions/yarn-install
+    - name: Read current RNVersion
+      shell: bash
+      id: read-rn-version
+      run: |
+        echo "rn-version=$(jq -r '.version' packages/react-native/package.json)" >> $GITHUB_OUTPUT
     - name: Set React Native Version
       # We don't want to set the version for stable branches, because this has been
       # already set from the 'create release' commits on the release branch.
-      if: ${{ !endsWith(github.ref_name, '-stable') }}
+      # For testing RC.0, though, the version has not been set yet. In that case, we are on Stable branch and
+      # it is the only case when the version is still 1000.0.0
+      if: ${{ !endsWith(github.ref_name, '-stable') || endsWith(github.ref_name, '-stable') && steps.read-rn-version.outputs.rn-version == '1000.0.0' }}
       shell: bash
       run: node ./scripts/releases/set-rn-artifacts-version.js --build-type ${{ inputs.release-type }}
     - name: Setup gradle

.github/actions/setup-node/action.yml

@@ -4,7 +4,7 @@ inputs:
   node-version:
     description: 'The node.js version to use'
     required: false
-    default: '22.11.0'
+    default: '22.14.0'
 runs:
   using: "composite"
   steps:

.github/actions/test-ios-rntester/action.yml

@@ -6,7 +6,7 @@ inputs:
     default: 2.6.10
   run-unit-tests:
     description: whether unit tests should run or not.
-    default: "true"
+    default: false
   flavor:
     description: The flavor of the build. Must be one of "Debug", "Release".
     default: Debug

.github/scripts/__tests__/__fixtures__/resolve-hermes.cjs

@@ -54,6 +54,14 @@ const propertiesPath = path.resolve(
 );
 const readFileSync = fs.readFileSync;
 fs.readFileSync = function (file, ...args) {
+  if (process.env.HERMES_TEST_REFS != null) {
+    const refs = JSON.parse(process.env.HERMES_TEST_REFS);
+    for (const [tagFile, ref] of Object.entries(refs)) {
+      if (file === path.resolve(propertiesPath, '../..', tagFile)) {
+        return ref;
+      }
+    }
+  }
   if (file === propertiesPath && process.env.HERMES_TEST_PROPERTIES != null) {
     if (process.env.HERMES_TEST_PROPERTIES === 'MISSING') {
       throw Object.assign(new Error(`ENOENT: ${propertiesPath}`), {

.github/scripts/__tests__/resolve-hermes-test.js

@@ -19,7 +19,8 @@ const {
 } = require('../../../packages/react-native/scripts/ios-prebuild/hermes-version');
 
 const root = path.resolve(__dirname, '../../..');
-const {version: v1Version} = readHermesMetadata('legacy-default', '1');
+const {version: v0Version} = readHermesMetadata('v1-default', '0');
+const {version: v1Version} = readHermesMetadata('v1-default', '1');
 const script = path.join(root, '.github/scripts/resolve-hermes.mts');
 const preload = path.join(__dirname, '__fixtures__/resolve-hermes.cjs');
 const sourceCommit = '1234567890abcdef1234567890abcdef12345678';
@@ -43,6 +44,7 @@ function run(command, overrides = {}) {
     'HERMES_TEST_DOWNLOAD',
     'HERMES_TEST_COMMIT',
     'HERMES_TEST_SOURCE_ERROR',
+    'HERMES_TEST_REFS',
   ]) {
     delete env[key];
   }
@@ -75,9 +77,11 @@ function run(command, overrides = {}) {
 }
 
 test.each([
-  [undefined, '123.4.56', 'HERMES_VERSION_NAME', 'Debug'],
-  ['0', '123.4.56', 'HERMES_VERSION_NAME', 'Debug'],
+  [undefined, v1Version, 'HERMES_V1_VERSION_NAME', 'Debug'],
+  ['0', v0Version, 'HERMES_VERSION_NAME', 'Debug'],
   ['1', v1Version, 'HERMES_V1_VERSION_NAME', 'Release'],
+  ['', v1Version, 'HERMES_V1_VERSION_NAME', 'Debug'],
+  ['true', v1Version, 'HERMES_V1_VERSION_NAME', 'Debug'],
 ])(
   'CI downloads flag %s with the selected key and version',
   (flag, version, key, flavor) => {
@@ -112,11 +116,30 @@ test.each([
   },
 );
 
-test('CI snapshot fallback uses the five-argument URL helper contract', () => {
+test.each([
+  [undefined, '250829098.0.9'],
+  ['0', '0.15.1'],
+  ['1', '250829098.0.9'],
+])('CI downloads checked-in stable metadata with flag %s', (flag, version) => {
+  const result = run(['download-hermes'], {
+    ...(flag == null ? {} : {RCT_HERMES_V1_ENABLED: flag}),
+    HERMES_TEST_DOWNLOAD: 'release',
+  });
+  expect(result.status).toBe(0);
+  expect(result.output).toContain(`version=${version}\n`);
+  expect(result.output).toMatch(/^tarball=.+$/m);
+  expect(result.urls).toEqual([
+    `https://central.sonatype.com/repository/maven-snapshots/com/facebook/hermes/hermes-ios/${version}-SNAPSHOT/maven-metadata.xml`,
+    `https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${version}/hermes-ios-${version}-hermes-ios-debug.tar.gz`,
+  ]);
+  expect(result.calls.source).toEqual([]);
+});
+
+test('CI snapshot fallback uses the five-argument Hermes URL helper contract', () => {
   const version = '123.4.56';
   const result = run(['download-hermes'], {
     HERMES_TEST_DOWNLOAD: 'snapshot',
-    HERMES_TEST_PROPERTIES: `HERMES_VERSION_NAME=${version}`,
+    HERMES_TEST_PROPERTIES: `HERMES_V1_VERSION_NAME=${version}`,
   });
   expect(result.status).toBe(0);
   expect(result.output).toContain(`version=${version}\n`);
@@ -135,7 +158,7 @@ test('CI snapshot fallback uses the five-argument URL helper contract', () => {
 
 test('CI can still select source when valid pinned artifacts are unavailable', () => {
   const result = run(['download-hermes'], {
-    HERMES_TEST_PROPERTIES: 'HERMES_VERSION_NAME=123.4.56',
+    HERMES_TEST_PROPERTIES: 'HERMES_V1_VERSION_NAME=123.4.56',
   });
   expect(result.status).toBe(0);
   expect(result.output).toBe('');
@@ -145,12 +168,16 @@ test('CI can still select source when valid pinned artifacts are unavailable', (
 });
 
 const invalidMetadata = [
-  ['', 'Expected one exact HERMES_VERSION_NAME'],
+  ['', 'Expected one exact HERMES_V1_VERSION_NAME'],
   ['UNREADABLE', 'EACCES'],
-  ['HERMES_VERSION_NAME=^1.2.3', 'Expected one exact HERMES_VERSION_NAME'],
   [
-    'HERMES_VERSION_NAME=1.2.3\nHERMES_VERSION_NAME=1.2.3',
-    'Expected one exact HERMES_VERSION_NAME',
+    'HERMES_V1_VERSION_NAME=^1.2.3',
+    'Expected one exact HERMES_V1_VERSION_NAME',
+  ],
+  ['HERMES_VERSION_NAME=1.2.3', 'Expected one exact HERMES_V1_VERSION_NAME'],
+  [
+    'HERMES_V1_VERSION_NAME=1.2.3\nHERMES_V1_VERSION_NAME=1.2.3',
+    'Expected one exact HERMES_V1_VERSION_NAME',
   ],
 ];
 
@@ -193,17 +220,17 @@ test('CI selects source without a download when version.properties is missing',
 });
 
 test.each([
-  [undefined, 'HERMES_VERSION_NAME', undefined],
-  ['0', 'HERMES_VERSION_NAME', undefined],
-  [
-    '1',
-    'HERMES_V1_VERSION_NAME',
-    'HERMES_VERSION_NAME=123.4.56\nHERMES_V1_VERSION_NAME=1000.0.0',
-  ],
-])('CI selected sentinel for flag %s', (flag, key, properties) => {
+  [undefined, 'HERMES_V1_VERSION_NAME'],
+  ['0', 'HERMES_VERSION_NAME'],
+  ['1', 'HERMES_V1_VERSION_NAME'],
+  ['', 'HERMES_V1_VERSION_NAME'],
+  ['true', 'HERMES_V1_VERSION_NAME'],
+])('CI selected sentinel for flag %s', (flag, key) => {
   const overrides = {
     ...(flag == null ? {} : {RCT_HERMES_V1_ENABLED: flag}),
-    ...(properties == null ? {} : {HERMES_TEST_PROPERTIES: properties}),
+    HERMES_TEST_PROPERTIES:
+      `${key}=1000.0.0\n` +
+      `${key === 'HERMES_VERSION_NAME' ? 'HERMES_V1_VERSION_NAME' : 'HERMES_VERSION_NAME'}=123.4.56`,
   };
 
   const download = run(['download-hermes'], overrides);
@@ -224,14 +251,18 @@ test.each([
 
 test('CI source resolution uses the current helper SHA for the cache output', () => {
   const commit = 'abcdef1234567890abcdef1234567890abcdef12';
-  const result = run(['resolve-commit'], {HERMES_TEST_COMMIT: commit});
+  const result = run(['resolve-commit'], {
+    HERMES_TEST_COMMIT: commit,
+    HERMES_TEST_PROPERTIES: 'HERMES_V1_VERSION_NAME=1000.0.0',
+  });
   expect(result.status).toBe(0);
   expect(result.output).toBe(`hermes-commit=${commit}\n`);
   expect(result.calls).toEqual({source: [[]], nightly: []});
 });
 
 test('CI fails source resolution without falling back to a tag', () => {
   const result = run(['resolve-commit'], {
+    HERMES_TEST_PROPERTIES: 'HERMES_V1_VERSION_NAME=1000.0.0',
     HERMES_TEST_SOURCE_ERROR: 'Cannot resolve merge-base timestamp',
   });
   expect(result.status).toBe(1);
@@ -241,15 +272,15 @@ test('CI fails source resolution without falling back to a tag', () => {
   expect(result.calls).toEqual({source: [[]], nightly: []});
 });
 
-test('CI resolve-commit emits the checked-in V1 SHA for concrete metadata', () => {
+test('CI resolve-commit emits the checked-in stable V1 tag', () => {
   const ref = fs
     .readFileSync(
       path.join(root, 'packages/react-native/sdks/.hermesv1version'),
       'utf8',
     )
     .trim();
-  expect(ref).toMatch(/^[0-9a-fA-F]{40}$/);
-  expect(v1Version).not.toBe('1000.0.0');
+  expect(ref).toBe('hermes-v250829098.0.9');
+  expect(v1Version).toBe('250829098.0.9');
 
   const result = run(['resolve-commit'], {RCT_HERMES_V1_ENABLED: '1'});
   expect(result.status).toBe(0);
@@ -259,17 +290,51 @@ test('CI resolve-commit emits the checked-in V1 SHA for concrete metadata', () =
   expect(result.calls).toEqual({source: [], nightly: []});
 });
 
+describe.each(['release/custom-hermes', sourceCommit])('source ref %s', ref => {
+  test.each([
+    [undefined, '.hermesv1version'],
+    ['0', '.hermesversion'],
+    ['1', '.hermesv1version'],
+    ['', '.hermesv1version'],
+    ['true', '.hermesv1version'],
+  ])('CI reads the selected file for flag %s', (flag, tagFile) => {
+    const result = run(['resolve-commit'], {
+      ...(flag == null ? {} : {RCT_HERMES_V1_ENABLED: flag}),
+      HERMES_TEST_PROPERTIES:
+        'HERMES_VERSION_NAME=123.4.56\nHERMES_V1_VERSION_NAME=234.5.67',
+      HERMES_TEST_REFS: JSON.stringify({
+        '.hermesversion': 'unselected-legacy-ref',
+        '.hermesv1version': 'unselected-v1-ref',
+        [tagFile]: ` ${ref}\n`,
+      }),
+    });
+    expect(result.status).toBe(0);
+    expect(result.output).toBe(`hermes-commit=${ref}\n`);
+    expect(result.urls).toEqual([]);
+    expect(result.calls).toEqual({source: [], nightly: []});
+  });
+});
+
 test.each([
-  [undefined, '.hermesversion', 'MISSING'],
+  [undefined, '.hermesv1version', 'MISSING'],
   ['0', '.hermesversion', 'MISSING'],
   ['1', '.hermesv1version', 'MISSING'],
-  [undefined, '.hermesversion', 'HERMES_VERSION_NAME=123.4.56'],
+  [undefined, '.hermesv1version', 'HERMES_V1_VERSION_NAME=123.4.56'],
+  [
+    undefined,
+    '.hermesv1version',
+    'HERMES_VERSION_NAME=1000.0.0\nHERMES_V1_VERSION_NAME=123.4.56',
+  ],
   [
     '0',
     '.hermesversion',
     'HERMES_VERSION_NAME=123.4.56\nHERMES_V1_VERSION_NAME=1000.0.0',
   ],
+  [undefined, '.hermesv1version', undefined],
+  ['0', '.hermesversion', undefined],
   ['1', '.hermesv1version', undefined],
+  ['', '.hermesv1version', undefined],
+  ['true', '.hermesv1version', undefined],
 ])(
   'CI resolve-commit reads flag %s tag %s independently of metadata %s',
   (flag, tagFile, properties) => {

.github/scripts/resolve-hermes.mts

@@ -40,10 +40,11 @@ function setActionOutput(key: string, value: string) {
  *
  * Uses the same version key and validation as the local prebuild script.
  * A missing file permits a source build; malformed metadata must fail CI.
+ * Selects V1 unless RCT_HERMES_V1_ENABLED=0, matching React Native 0.84.
  */
 function resolveHermesArtifactVersion(): string | null {
   try {
-    const {version, versionKey} = readHermesMetadata('legacy-default');
+    const {version, versionKey} = readHermesMetadata('v1-default');
     echo(`Using ${versionKey}=${version}`);
     return version;
   } catch (error: any) {
@@ -56,12 +57,12 @@ function resolveHermesArtifactVersion(): string | null {
 
 /**
  * Reads the pinned Hermes ref from packages/react-native/sdks/.hermesversion
- * (or .hermesv1version when RCT_HERMES_V1_ENABLED=1). The value is a tag or commit in
+ * (or .hermesv1version unless V1 is explicitly disabled). The value is a tag or commit in
  * facebook/hermes. Returns null if the file is missing or empty.
  */
 function resolveHermesTag(): string | null {
   const {tagFile} = selectHermesMetadata(
-    'legacy-default', process.env.RCT_HERMES_V1_ENABLED,
+    'v1-default', process.env.RCT_HERMES_V1_ENABLED,
   );
   const tagPath = path.resolve(
     import.meta.dirname!, '..', '..',

.github/workflows/bump-podfile-lock.yml

@@ -37,8 +37,9 @@ jobs:
       - name: Bump podfile.lock
         run: |
           cd packages/rn-tester
+          rm Podfile.lock
           bundle install
-          bundle exec pod update hermes-engine --no-repo-update
+          bundle exec pod install
       - name: Commit changes
         run: |
           git add packages/rn-tester/Podfile.lock

.github/workflows/cache-reaper.yml

@@ -8,7 +8,7 @@ on:
 
 jobs:
   cache-cleaner:
-    if: github.repository == 'facebook/react-native'
+    if: github.repository == 'react/react-native'
     runs-on: ubuntu-latest
     env:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/check-for-reproducer.yml

@@ -8,7 +8,7 @@ jobs:
   check-for-reproducer:
     runs-on: ubuntu-latest
     if: |
-      github.repository == 'facebook/react-native' && github.event.issue.pull_request == null && github.event.issue.state == 'open' && !contains(github.event.issue.labels.*.name, ':open_umbrella: Umbrella')
+      github.repository == 'react/react-native' && github.event.issue.pull_request == null && github.event.issue.state == 'open' && !contains(github.event.issue.labels.*.name, ':open_umbrella: Umbrella')
     steps:
       - uses: actions/checkout@v6
       - uses: actions/github-script@v8

.github/workflows/close-pr.yml

@@ -9,7 +9,7 @@ permissions:
 jobs:
   comment-and-label:
     runs-on: ubuntu-latest
-    if: github.repository == 'facebook/react-native'
+    if: github.repository == 'react/react-native'
     steps:
       - uses: actions/github-script@v8
         with:

.github/workflows/create-release.yml

@@ -19,7 +19,7 @@ on:
 
 jobs:
   create_release:
-    if: github.repository == 'facebook/react-native'
+    if: github.repository == 'react/react-native'
     runs-on: ubuntu-latest
     steps:
       - name: Checkout

.github/workflows/danger-pr.yml

@@ -15,7 +15,7 @@ permissions:
 jobs:
   danger:
     runs-on: ubuntu-latest
-    if: github.repository == 'facebook/react-native'
+    if: github.repository == 'react/react-native'
     steps:
       - name: Check out PR branch
         uses: actions/checkout@v6

.github/workflows/monitor-new-issues.yml

@@ -12,7 +12,7 @@ on:
 jobs:
   monitor-issues:
     runs-on: ubuntu-latest
-    if: github.repository == 'facebook/react-native'
+    if: github.repository == 'react/react-native'
     steps:
       - name: Checkout
         uses: actions/checkout@v6
@@ -34,7 +34,7 @@ jobs:
           git_secret: ${{ secrets.GITHUB_TOKEN }}
           notifier: "discord"
           fetch_data_interval: 6
-          repo_owner: "facebook"
+          repo_owner: "react"
           repo_name: "react-native"
           discord_webhook_url: "${{ secrets.DISCORD_WEBHOOK_URL }}"
           discord_id_type: "user"

.github/workflows/needs-attention.yml

@@ -14,7 +14,7 @@ jobs:
       issues: write # for react-native-community/needs-attention to label issues
     name: Apply Needs Attention Label
     runs-on: ubuntu-latest
-    if: github.repository == 'facebook/react-native'
+    if: github.repository == 'react/react-native'
     steps:
       - uses: actions/checkout@v6
       - name: Apply Needs Attention Label