Skip to content

Load basic languages in Monarch playground - #5535

Open
lsmlhi_25 (FOWEPJF255) wants to merge 1 commit into
microsoft:mainfrom
FOWEPJF255:fix-monarch-embedded-examples
Open

lsmlhi_25 (FOWEPJF255) wants to merge 1 commit into
microsoft:mainfrom
FOWEPJF255:fix-monarch-embedded-examples

Conversation

@FOWEPJF255

Copy link
Copy Markdown

Fixes #4075.

The Monarch playground loads editor.main.js but does not load the basic-language contributions. As a result, embedded languages such as JavaScript in the HTML sample have no tokenizer registered and render as plain text. Load the basic-language contribution bundle before the Monarch playground script.

Verified:

  • npm run build-webpack in website completes.
  • npm test passes (86 tests).
  • Playwright confirms JavaScript keywords and strings in the HTML Monarch sample are tokenized after the change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] monaco monarch embedded language examples not behaving correctly

2 participants