Fix crash on malformed object destructuring assignment in decorated class - #64472
Open
Mateusz Burzyński (Andarist) wants to merge 2 commits into
Open
Mateusz Burzyński (Andarist) wants to merge 2 commits into
Mateusz Burzyński (Andarist) wants to merge 2 commits into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
September 26, 2026 19:13
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The crash should be fixed without removing an existing debug assertion and masking the visitor-contract violation.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds regression coverage for malformed object destructuring inside a decorated class.
Changes:
- Adds a malformed destructuring compiler test.
- Adds diagnostic, emit, symbol, and type baselines.
- Removes an assertion from the ES decorator transformer.
| File | Description |
|---|---|
tsc/internal/transformers/estransforms/esdecorator.go |
Avoids the reported crash by removing an assertion. |
tsc/testdata/tests/cases/compiler/malformedObjectDestructuringAssignmentESDecorators.ts |
Adds the regression case. |
tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentESDecorators.errors.txt |
Records expected diagnostics. |
tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentESDecorators.js |
Records expected emit. |
tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentESDecorators.symbols |
Records expected symbols. |
tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentESDecorators.types |
Records expected types. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| @@ -2261,7 +2261,6 @@ func (tx *esDecoratorTransformer) visitAssignmentRestProperty(node *ast.Node) *a | |||
| } | |||
|
|
|||
| func (tx *esDecoratorTransformer) visitObjectAssignmentElement(node *ast.Node) *ast.Node { | |||
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes a crash reported here: #64458 (comment)
This PR is similar to #63972 and #63973