Fix union overload signature ordering instability - #64360
Open
ADİL ALPEREN ÇİFTCİ (adilalperenciftci) wants to merge 3 commits into
Open
ADİL ALPEREN ÇİFTCİ (adilalperenciftci) wants to merge 3 commits into
ADİL ALPEREN ÇİFTCİ (adilalperenciftci) wants to merge 3 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Member
|
This seems a bit too ad-hoc and out of place for the kind of thing we normally do. It is suspicious that nothing else changed, either, and that it's purely additive? |
Author
|
Good point on the post-sorting. I dropped that approach and replaced it with a simpler change in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53614
Expands signatures with optional parameters into exact-arity variants during
getUnionSignaturesso candidate overloads resolve naturally infindMatchingSignatureswithout ad-hoc post-sorting.