Skip to content

Ignore not-found errors in Sentry #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecristen merged 2 commits into from
Oct 21, 2026
Merged

Ignore not-found errors in Sentry #3602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4764907
Ignore not-found errors in Sentry
thecristen Oct 15, 2026
1032ad1
remove the superfluous test
thecristen Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/sentry.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ defmodule Dotcom.Sentry do

# Phoenix.NotAcceptableError is returned when the client requests an unsupported format, we don't need to report these
defp exclude_exception?(%Phoenix.NotAcceptableError{}), do: true
# Not found errors are rendered as 404 responses by the router and don't need to be reported
defp exclude_exception?(%DotcomWeb.NotFoundError{}), do: true
# Exclude Redis connection/disconnection from Sentry
defp exclude_exception?(%Redix.ConnectionError{}), do: true
defp exclude_exception?(_exception), do: false
Expand Down
Loading