Repository navigation
docs: Remove the .fs-1 utility class from the design utilities page - #847
Draft
promptless-for-oss wants to merge 1 commit into
Draft
promptless-for-oss wants to merge 1 commit into
promptless-for-oss wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
Author
|
I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Description
mautic/mautic#17873 removes the
.fs-1utility class (flex-shrink: 1) on 8.x, because flex items already shrink by default.This PR updates the Flex shrink properties section of
docs/design/utilities.rst:.fs-1entry..fs-1-sm,.fs-1-md, and.fs-1-lgresponsive classes, which stay in 8.x, for letting an item with.fs-0shrink again from a breakpoint and up.Vale passes with no new findings on the changed lines.
Linked issue
Related to mautic/mautic#17873
Screenshots or screen recordings
Not applicable. This PR doesn't change the UI.
Trigger Events