Repository navigation
docs: Describe the voter as the only API permission-context event dispatcher (8.0) - #845
Draft
promptless-for-oss wants to merge 1 commit into
Draft
promptless-for-oss wants to merge 1 commit into
promptless-for-oss wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Description
mautic/mautic#17853 removes
MauticDenyAccessListenerfrom the ApiBundle. The listener was never wired to any event, soApiPermissionVoteris the only place that dispatchesApiPlatformPermissionContextEvent.This PR updates the "API permission-context event" section of
docs/plugin_extensions/api.rst:getSecurityExpression(),getRequest(), andgetAttributes()descriptions to match what the voter passes to the event.getRequest()returnsnullandgetAttributes()returns an empty array.Verified against
ApiPermissionVoter::voteOnAttribute()andApiPlatformPermissionContextEventon8.x. Vale reports no new findings.Linked issue
None. Source change: mautic/mautic#17853
Screenshots or screen recordings
Not applicable.
Trigger Events