Skip to content

fix: do not continue a block quote paragraph from a whitespace-only line #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UziTech merged 1 commit into from
Oct 26, 2026
+23 −1
Merged

fix: do not continue a block quote paragraph from a whitespace-only line #4134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ const paragraph = createParagraph(/ {0,3}(?:[*+-]|1[.)])[ \t]+[^ \t\n]/);
// paragraph, where an empty list cannot interrupt)
const blockquoteParagraph = createParagraph(/ {0,3}(?:[*+-]|\d{1,9}[.)])(?:[ \t]|\n|$)/);

const blockquote = edit(/^( {0,3}> ?(paragraph|[^\n]*)(?:\n|$))+/)
// a line with only whitespace after the marker is blank, so it must not start a
// paragraph that lazily continues onto the next line
const blockquote = edit(/^( {0,3}> ?(?:(?![ \t]*(?:\n|$))(paragraph)|[^\n]*)(?:\n|$))+/)
.replace('paragraph', blockquoteParagraph)
.getRegex();

Expand Down
3 changes: 3 additions & 0 deletions test/specs/new/blockquote_whitespace_only_empty.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<blockquote>
</blockquote>
<p>b</p>
2 changes: 2 additions & 0 deletions test/specs/new/blockquote_whitespace_only_empty.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
>
b
8 changes: 8 additions & 0 deletions test/specs/new/blockquote_whitespace_only_line.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<blockquote>
<p>a</p>
</blockquote>
<p>b</p>
<blockquote>
<p>c</p>
</blockquote>
<p>d</p>
7 changes: 7 additions & 0 deletions test/specs/new/blockquote_whitespace_only_line.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
> a
>
b

> c
>
d
Loading