Skip to content

fix: render nested image alt formatting as plain text #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UziTech merged 2 commits into from
Oct 26, 2026
+33 −10
Merged

fix: render nested image alt formatting as plain text #4131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6bda6e
fix: render nested image alt formatting as plain text
Kesavamoorthig06 Oct 11, 2026
e9245d9
test: move nested image alt regressions to spec fixtures
Kesavamoorthig06 Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export class _Parser<ParserOutput = string, RendererOutput = string> {
this.renderer.options = this.options;
this.renderer.parser = this;
this.textRenderer = new _TextRenderer<RendererOutput>();
this.textRenderer.parser = this;
}

/**
Expand Down
22 changes: 12 additions & 10 deletions src/TextRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,27 @@
import type { Tokens } from './Tokens.ts';
import type { _Parser } from './Parser.ts';

/**
* TextRenderer
* returns only the textual part of the token
*/
export class _TextRenderer<RendererOutput = string> {
parser!: _Parser<unknown, RendererOutput>;
// no need for block level renderers
strong({ text }: Tokens.Strong): RendererOutput {
return text as RendererOutput;
strong({ text, tokens }: Tokens.Strong): RendererOutput {
return (tokens ? this.parser.parseInline(tokens, this) : text) as RendererOutput;
}

em({ text }: Tokens.Em): RendererOutput {
return text as RendererOutput;
em({ text, tokens }: Tokens.Em): RendererOutput {
return (tokens ? this.parser.parseInline(tokens, this) : text) as RendererOutput;
}

codespan({ text }: Tokens.Codespan): RendererOutput {
return text as RendererOutput;
}

del({ text }: Tokens.Del): RendererOutput {
return text as RendererOutput;
del({ text, tokens }: Tokens.Del): RendererOutput {
return (tokens ? this.parser.parseInline(tokens, this) : text) as RendererOutput;
}

html({ text }: Tokens.HTML | Tokens.Tag): RendererOutput {
Expand All @@ -30,12 +32,12 @@ export class _TextRenderer<RendererOutput = string> {
return text as RendererOutput;
}

link({ text }: Tokens.Link): RendererOutput {
return '' + text as RendererOutput;
link({ text, tokens }: Tokens.Link): RendererOutput {
return (tokens ? this.parser.parseInline(tokens, this) : text) as RendererOutput;
}

image({ text }: Tokens.Image): RendererOutput {
return '' + text as RendererOutput;
image({ text, tokens }: Tokens.Image): RendererOutput {
return (tokens ? this.parser.parseInline(tokens, this) : text) as RendererOutput;
}

br(): RendererOutput {
Expand Down
7 changes: 7 additions & 0 deletions test/specs/new/image_alt_nested_formatting.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<p><img src="image.png" alt="a b"></p>
<p><img src="image.png" alt="a b"></p>
<p><img src="image.png" alt="a b"></p>
<p><img src="image.png" alt="a b"></p>
<p><img src="image.png" alt="a b"></p>
<p><img src="image.png" alt="a b"></p>
<p><img src="image.png" alt="a *b*"></p>
13 changes: 13 additions & 0 deletions test/specs/new/image_alt_nested_formatting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
![**a *b***](image.png)

![*a **b***](image.png)

![**a `b`**](image.png)

![~~a **b**~~](image.png)

![[a **b**](url)](image.png)

![![a **b**](inner)](image.png)

![**a `*b*`**](image.png)
Loading